Skip to content

crypto/internal/boring: make dst allocation for AES-GCM more efficient #74740

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 8 commits into
base: master
Choose a base branch
from
+8 −6
Open

crypto/internal/boring: make dst allocation for AES-GCM more efficient #74740

Changes from all commits
Commits
Show all changes
8 commits
Select commit Hold shift + click to select a range
c3411e1
Make buffer allocation for AES-GCM more efficient.
juergw Jul 24, 2025
e962c24
Use append instead of allocating new dst by hand.
juergw Jul 25, 2025
661106f
Merge branch 'golang:master' into master
juergw Jul 25, 2025
91b37d7
Inline expressions.
juergw Jul 25, 2025
4af65de
Fix whitespace.
juergw Jul 25, 2025
7f74ac2
Merge branch 'golang:master' into master
juergw Jul 29, 2025
920a598
Don't first zero output if dst has enough capacity.
juergw Jul 29, 2025
524845a
Changes.
juergw Jul 29, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
14 changes: 8 additions & 6 deletions src/crypto/internal/boring/aes.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -323,10 +323,11 @@ func (g *aesGCM) Seal(dst, nonce, plaintext, additionalData []byte) []byte {

// Make room in dst to append plaintext+overhead.
n := len(dst)
for cap(dst) < n+len(plaintext)+gcmTagSize {
dst = append(dst[:cap(dst)], 0)
if total := n+len(plaintext)+gcmTagSize; cap(dst) >= total {
dst = dst[:total]
} else {
dst = append(dst, make([]byte, len(plaintext)+gcmTagSize)...)
}
dst = dst[:n+len(plaintext)+gcmTagSize]

// Check delayed until now to make sure len(dst) is accurate.
if inexactOverlap(dst[n:], plaintext) {
Expand Down Expand Up @@ -362,10 +363,11 @@ func (g *aesGCM) Open(dst, nonce, ciphertext, additionalData []byte) ([]byte, er

// Make room in dst to append ciphertext without tag.
n := len(dst)
for cap(dst) < n+len(ciphertext)-gcmTagSize {
dst = append(dst[:cap(dst)], 0)
if total := n+len(ciphertext)-gcmTagSize; cap(dst) >= total {
dst = dst[:total]
} else {
dst = append(dst, make([]byte, len(ciphertext)-gcmTagSize)...)
}
dst = dst[:n+len(ciphertext)-gcmTagSize]

// Check delayed until now to make sure len(dst) is accurate.
if inexactOverlap(dst[n:], ciphertext) {
Expand Down