-
Notifications
You must be signed in to change notification settings - Fork 18.8k
internal/trace: fix recorder.Write return value for header-only buffers #77092
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
This PR (HEAD: bb24cbd) has been imported to Gerrit for code review. Please visit Gerrit at https://go-review.googlesource.com/c/go/+/734300. Important tips:
|
|
Message from Gopher Robot: Patch Set 1: (1 comment) Please don’t reply on this GitHub thread. Visit golang.org/cl/734300. |
|
Message from Jorge Pinto: Patch Set 1: (1 comment) Please don’t reply on this GitHub thread. Visit golang.org/cl/734300. |
|
Message from Michael Pratt: Patch Set 1: Code-Review+1 (1 comment) Please don’t reply on this GitHub thread. Visit golang.org/cl/734300. |
|
Message from Michael Pratt: Patch Set 1: Commit-Queue+1 Please don’t reply on this GitHub thread. Visit golang.org/cl/734300. |
|
Message from Go LUCI: Patch Set 1: Dry run: CV is trying the patch. Bot data: {"action":"start","triggered_at":"2026-01-07T01:50:55Z","revision":"35f6875114786a3c769973368e91d6276846f326"} Please don’t reply on this GitHub thread. Visit golang.org/cl/734300. |
|
Message from Michael Pratt: Patch Set 1: -Commit-Queue Please don’t reply on this GitHub thread. Visit golang.org/cl/734300. |
|
Message from Go LUCI: Patch Set 1: This CL has passed the run Please don’t reply on this GitHub thread. Visit golang.org/cl/734300. |
|
Message from Go LUCI: Patch Set 1: LUCI-TryBot-Result+1 Please don’t reply on this GitHub thread. Visit golang.org/cl/734300. |
|
Message from Michael Knyszek: Patch Set 1: Code-Review+2 (1 comment) Please don’t reply on this GitHub thread. Visit golang.org/cl/734300. |
|
Message from Michael Knyszek: Patch Set 1: (1 comment) Please don’t reply on this GitHub thread. Visit golang.org/cl/734300. |
|
Message from Michael Knyszek: Patch Set 1: Commit-Queue+2 Please don’t reply on this GitHub thread. Visit golang.org/cl/734300. |
Fix issue #77083 Change-Id: I9189d1e3a6efea8478224164e820f50c818abcd5 GitHub-Last-Rev: bb24cbd GitHub-Pull-Request: #77092 Reviewed-on: https://go-review.googlesource.com/c/go/+/734300 Reviewed-by: Michael Pratt <[email protected]> Reviewed-by: Michael Knyszek <[email protected]> Commit-Queue: Michael Knyszek <[email protected]> LUCI-TryBot-Result: Go LUCI <[email protected]>
|
Message from Go LUCI: Patch Set 1: CV is trying the patch. Bot data: {"action":"start","triggered_at":"2026-01-07T19:53:07Z","revision":"35f6875114786a3c769973368e91d6276846f326"} Please don’t reply on this GitHub thread. Visit golang.org/cl/734300. |
|
This PR is being closed because golang.org/cl/734300 has been merged. |
Fix issue #77083