gopls/internal/analysis/modernize add space for fix stringscutprefix#582
gopls/internal/analysis/modernize add space for fix stringscutprefix#582gan-of-culture wants to merge 1 commit intogolang:masterfrom
Conversation
Added a space so the fix does match the pattern shown in the description / comments. Without this change the fix of the code would be edited to this: after, ok :=strings.CutPrefix... After the change it should looks like this: after, ok := strings.CutPrefix... Will add the space anyway, but it would be nice to have the space out of the box.
|
Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA). View this failed invocation of the CLA check for more information. For the most up to date status, view the checks section at the bottom of the pull request. |
|
This PR (HEAD: 2f6189e) has been imported to Gerrit for code review. Please visit Gerrit at https://go-review.googlesource.com/c/tools/+/685875. Important tips:
|
|
Message from Gopher Robot: Patch Set 1: (1 comment) Please don’t reply on this GitHub thread. Visit golang.org/cl/685875. |
|
Message from Gopher Robot: Patch Set 1: Congratulations on opening your first change. Thank you for your contribution! Next steps: Most changes in the Go project go through a few rounds of revision. This can be Please don’t reply on this GitHub thread. Visit golang.org/cl/685875. |
|
Message from Tim Cook: Patch Set 2: (1 comment) Please don’t reply on this GitHub thread. Visit golang.org/cl/685875. |
Added a space so the fix does match the pattern shown in
the description / comments.
Without this change the fix of the code would be edited to this:
after, ok :=strings.CutPrefix...After the change it should looks like this:
after, ok := strings.CutPrefix...Gofmt will add the space anyway, but it would be nice to have
the space out of the box.