Skip to content

Commit 13eebda

Browse files
committed
extension/test/integration: disable local dlv install tests
For go1.19 and go1.20, the extension tries to install a pinned version of dlv (the last version that is compatible with the old go version). The local proxy used for testing does not have the pinned version so the test fails. Ironically this test failure indicates the dlv install logic works as expected. Since the fix is non-trivial and hard to be done before v0.42.0 release, skip them in go1.19/go1.20 CI. For #3454 Change-Id: Iccd9d905ab46adf255c52d82817046d4fb85fe81 Reviewed-on: https://go-review.googlesource.com/c/vscode-go/+/598196 Commit-Queue: Hyang-Ah Hana Kim <[email protected]> Reviewed-by: Hongxiang Jiang <[email protected]> kokoro-CI: kokoro <[email protected]>
1 parent 64865db commit 13eebda

File tree

1 file changed

+12
-2
lines changed

1 file changed

+12
-2
lines changed

extension/test/integration/install.test.ts

Lines changed: 12 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -189,7 +189,12 @@ suite('Installation Tests', function () {
189189
);
190190
});
191191

192-
test('Install multiple tools with a local proxy', async () => {
192+
test('Install multiple tools with a local proxy', async function () {
193+
// TODO(golang/vscode-go#3454): reenable the test for old go.
194+
const systemGoVersion = await getGoVersion();
195+
if (systemGoVersion.lt('1.21')) {
196+
this.skip();
197+
}
193198
await runTest(
194199
[
195200
{ name: 'gopls', versions: ['v0.1.0', 'v1.0.0-pre.1', 'v1.0.0'], wantVersion: 'v1.0.0' },
@@ -199,7 +204,12 @@ suite('Installation Tests', function () {
199204
);
200205
});
201206

202-
test('Install multiple tools with a local proxy & GOBIN', async () => {
207+
test('Install multiple tools with a local proxy & GOBIN', async function () {
208+
// TODO(golang/vscode-go#3454): reenable the test for old go.
209+
const systemGoVersion = await getGoVersion();
210+
if (systemGoVersion.lt('1.21')) {
211+
this.skip();
212+
}
203213
await runTest(
204214
[
205215
{ name: 'gopls', versions: ['v0.1.0', 'v1.0.0-pre.1', 'v1.0.0'], wantVersion: 'v1.0.0' },

0 commit comments

Comments
 (0)