review

Author: ldez

pkg/commands/internal/migrate/migrate_formatters.go

@@ -19,6 +19,8 @@ func toFormatters(old *versionone.Config) versiontwo.Formatters {
 		paths = slices.Concat(old.Issues.ExcludeFiles, old.Issues.ExcludeDirs)
 	}
 
+	paths = append(paths, toFormattersPathsFromRules(old.Issues)...)
+
 	return versiontwo.Formatters{
 		Enable: formatterNames,
 		Settings: versiontwo.FormatterSettings{
@@ -34,6 +36,27 @@ func toFormatters(old *versionone.Config) versiontwo.Formatters {
 	}
 }
 
+func toFormattersPathsFromRules(old versionone.Issues) []string {
+	var results []string
+
+	for _, rule := range old.ExcludeRules {
+		allNames := convertStaticcheckLinterNames(convertAlternativeNames(rule.Linters))
+
+		names := onlyFormatterNames(allNames)
+		if len(names) == 0 {
+			continue
+		}
+
+		if ptr.Deref(rule.Path) == "" {
+			continue
+		}
+
+		results = append(results, ptr.Deref(rule.Path))
+	}
+
+	return results
+}
+
 func toGciSettings(old versionone.GciSettings) versiontwo.GciSettings {
 	return versiontwo.GciSettings{
 		Sections:         old.Sections,

pkg/commands/internal/migrate/migrate_linters_exclusions.go

@@ -64,9 +64,14 @@ func toExclusionRules(old *versionone.Config) []versiontwo.ExcludeRule {
 	var results []versiontwo.ExcludeRule
 
 	for _, rule := range old.Issues.ExcludeRules {
+		names := onlyLinterNames(convertStaticcheckLinterNames(convertAlternativeNames(rule.Linters)))
+		if len(rule.Linters) > 0 && len(names) == 0 {
+			continue
+		}
+
 		results = append(results, versiontwo.ExcludeRule{
 			BaseRule: versiontwo.BaseRule{
-				Linters:    onlyLinterNames(convertStaticcheckLinterNames(convertAlternativeNames(rule.Linters))),
+				Linters:    names,
 				Path:       rule.Path,
 				PathExcept: rule.PathExcept,
 				Text:       addPrefix(old.Issues, rule.Text),

pkg/commands/internal/migrate/testdata/issues_10.golden.yml

@@ -0,0 +1,9 @@
+version: "2"
+linters:
+  default: none
+formatters:
+  enable:
+    - goimports
+  exclusions:
+    paths:
+      - \.(generated\.deepcopy|pb)\.go$

pkg/commands/internal/migrate/testdata/issues_10.yml

@@ -0,0 +1,15 @@
+issues:
+  # Only to not generate unrelated elements inside golden.
+  exclude-generated: strict
+  # Only to not generate unrelated elements inside golden.
+  exclude-dirs-use-default: false
+
+  exclude-rules:
+    - path: "\\.(generated\\.deepcopy|pb)\\.go$"
+      linters:
+        - goimports
+
+linters:
+  disable-all: true
+  enable:
+    - goimports