feat: Formatter to Analyzer converter

Author: ldez

pkg/goformatters/analyzer.go

@@ -0,0 +1,55 @@
+package goformatters
+
+import (
+	"bytes"
+	"fmt"
+	"os"
+	"path/filepath"
+
+	"github.com/rogpeppe/go-internal/diff"
+	"golang.org/x/tools/go/analysis"
+
+	"github.com/golangci/golangci-lint/pkg/goanalysis"
+	"github.com/golangci/golangci-lint/pkg/goformatters/internal"
+	"github.com/golangci/golangci-lint/pkg/logutils"
+)
+
+// NewAnalyzer converts a [Formatter] to an [analysis.Analyzer].
+func NewAnalyzer(logger logutils.Log, doc string, formatter Formatter) *analysis.Analyzer {
+	return &analysis.Analyzer{
+		Name: formatter.Name(),
+		Doc:  doc,
+		Run: func(pass *analysis.Pass) (any, error) {
+			for _, file := range pass.Files {
+				position, isGoFiles := goanalysis.GetGoFilePosition(pass, file)
+				if !isGoFiles {
+					continue
+				}
+
+				input, err := os.ReadFile(position.Filename)
+				if err != nil {
+					return nil, fmt.Errorf("unable to open file %s: %w", position.Filename, err)
+				}
+
+				output, err := formatter.Format(position.Filename, input)
+				if err != nil {
+					return nil, fmt.Errorf("error while running %s: %w", formatter.Name(), err)
+				}
+
+				if !bytes.Equal(input, output) {
+					newName := filepath.ToSlash(position.Filename)
+					oldName := newName + ".orig"
+
+					theDiff := diff.Diff(oldName, input, newName, output)
+
+					err = internal.ExtractDiagnosticFromPatch(pass, file, string(theDiff), logger)
+					if err != nil {
+						return nil, fmt.Errorf("can't extract issues from %s diff output %q: %w", formatter.Name(), string(theDiff), err)
+					}
+				}
+			}
+
+			return nil, nil
+		},
+	}
+}

pkg/golinters/internal/diff.go renamed to pkg/goformatters/internal/diff.go

@@ -12,7 +12,6 @@ import (
 	"golang.org/x/tools/go/analysis"
 
 	"github.com/golangci/golangci-lint/pkg/goanalysis"
-	"github.com/golangci/golangci-lint/pkg/lint/linter"
 	"github.com/golangci/golangci-lint/pkg/logutils"
 )
 
@@ -215,7 +214,7 @@ func ExtractDiagnosticFromPatch(
 	pass *analysis.Pass,
 	file *ast.File,
 	patch string,
-	lintCtx *linter.Context,
+	logger logutils.Log,
 ) error {
 	diffs, err := diffpkg.ParseMultiFileDiff([]byte(patch))
 	if err != nil {
@@ -232,12 +231,12 @@ func ExtractDiagnosticFromPatch(
 
 	for _, d := range diffs {
 		if len(d.Hunks) == 0 {
-			lintCtx.Log.Warnf("Got no hunks in diff %+v", d)
+			logger.Warnf("Got no hunks in diff %+v", d)
 			continue
 		}
 
 		for _, hunk := range d.Hunks {
-			p := hunkChangesParser{log: lintCtx.Log}
+			p := hunkChangesParser{log: logger}
 
 			changes := p.parse(hunk)