Skip to content

feat: deprecate github-actions format #4726

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
May 19, 2024
Merged

feat: deprecate github-actions format #4726

Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
22c1925
feat: deprecate github-actions format
ldez May 17, 2024
c9c3b98
review: extend deprecation
ldez May 19, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 7 additions & 0 deletions pkg/config/loader.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -350,6 +350,13 @@ func (l *Loader) handleDeprecation() error {
l.cfg.Output.Formats = f
}

for _, format := range l.cfg.Output.Formats {
if format.Format == OutFormatGithubActions {
l.log.Warnf("The output format `%s` is deprecated, please use `%s`", OutFormatGithubActions, OutFormatColoredLineNumber)
break // To avoid repeating the message if there are several usages of github-actions format.
}
}

l.handleLinterOptionDeprecations()

return nil
Expand Down