dev: improve readability and maintenance of internal/cache
#5101
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
alexandear
reviewed
Nov 5, 2024
ldez
force-pushed
the
feat/improve-readability
branch
3 times, most recently
from
dd4b36c to
cc9a461
Compare
ldez
force-pushed
the
feat/improve-readability
branch
from
cc9a461 to
92fd8c8
Compare
alexandear
approved these changes
Nov 5, 2024
ldez
changed the title
internal/cacheinternal/cache
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Before reviewing the content of this PR, and if you want, I propose a quick "game" to illustrate the goal of this PR:
internal/cache/cache.golocallyGetis doingGetand do the same thingExtends
stopwatchto simplify the usage.Isolates usage of
iosem.Factorizes methods to increase the readability.
Follows #5100