Skip to content

dev: use secure links #5106

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Nov 6, 2024
Merged

dev: use secure links #5106

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
f8c4649
docs: use secure links in .gitignore
alexandear Nov 6, 2024
6386818
dev: improve testdata example code for mnd
alexandear Nov 6, 2024
f9b13d1
review
ldez Nov 6, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions docs/.gitignore
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -20,7 +20,7 @@ coverage
# nyc test coverage
.nyc_output

# Grunt intermediate storage (http://gruntjs.com/creating-plugins#storing-task-files)
# Grunt intermediate storage (https://gruntjs.com/creating-plugins#storing-task-files)
.grunt

# Bower dependency directory (https://bower.io/)
Expand All @@ -29,7 +29,7 @@ bower_components
# node-waf configuration
.lock-wscript

# Compiled binary addons (http://nodejs.org/api/addons.html)
# Compiled binary addons (https://nodejs.org/api/addons.html)
build/Release

# Dependency directories
Expand Down
6 changes: 4 additions & 2 deletions pkg/golinters/mnd/testdata/mnd.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -12,10 +12,11 @@ func UseMagicNumber() {
Timeout: 2 * time.Second, // want "Magic number: 2, in <assign> detected"
}

res, err := c.Get("http://www.google.com")
res, err := c.Get("https://www.google.com")
if err != nil {
log.Fatal(err)
}
defer res.Body.Close()
if res.StatusCode != 200 { // want "Magic number: 200, in <condition> detected"
log.Println("Something went wrong")
}
Expand All @@ -26,10 +27,11 @@ func UseNoMagicNumber() {
Timeout: time.Second,
}

res, err := c.Get("http://www.google.com")
res, err := c.Get("https://www.google.com")
if err != nil {
log.Fatal(err)
}

if res.StatusCode != http.StatusOK {
log.Println("Something went wrong")
}
Expand Down
Loading