dev: improve deprecated comments #5141
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ldez
added
declined
and removed
topic: cosmetic
|
This deprecation is a bit special, and not handled in this way. |
|
Wasn't this change just to clarify why it's deprecated/what to use instead to avoid tribal knowledge rather than some process or parsing? At least for me it's better to add some context to deprecation comments even if just for developers. |
|
The problem is that the comment is wrong: the GitHub action format is not replaced by another. |
|
Ah, I see, I misinterpreted your comment! Then it makes a lot more sense to not merge this! |
We can add the link to the comment with explanation: // Deprecated: not needed, see https://github.com/golangci/golangci-lint/issues/4695#issuecomment-2097087189 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.