docs: Update README generation #5147
Closed
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Team
section toContributors
since the list is only partly team members.golangci
organizationI don't think linking to a user's external web page is what's expected when clicking on a user's picture here on GitHub. On top of that we also don't have control on what potential sites we're linking to by doing so. Instead I think we should always link to the GitHub profile page and if someone want's to visit the web page from there they can click on the link in the profile.
While exploring this I noticed a few other things that I was addressing since they felt related. I reworded the list to contributors since it's not actually the team or team members. To address that I also made an extra call to the organization's team page to flag contributors who's also team members. This is not optimal and could be handled with a single call and some more code changes but given that the pipeline takes 1h 12m I don't think an extra roundtrip and loop over 500 items really matters.
Lastly since the images and alignment was rendered differently if the name was long enough to cause a line break I added some styling for that as well.