Skip to content

Conversation

alexandear
Copy link
Member

The PR refactors the Checkstyle.Print implementation to use xml.MarshalIndent instead of go-xmlfmt/xmlfmt.FormatXML. This allows dropping the github.com/go-xmlfmt/xmlfmt dependency.

@alexandear alexandear added the topic: cleanup Related to code, process, or doc cleanup label Nov 27, 2024
@ldez ldez added declined and removed topic: cleanup Related to code, process, or doc cleanup labels Nov 27, 2024
@ldez
Copy link
Member

ldez commented Nov 27, 2024

There is no problem with github.com/go-xmlfmt/xmlfmt, so we will not replace it.

@ldez ldez closed this Nov 27, 2024
@alexandear
Copy link
Member Author

There is no problem with github.com/go-xmlfmt/xmlfmt, so we will not replace it.

I proposed using xml.MarshalIndent from the Go standard library to minimize external dependencies and simplify maintenance. There is no need for an external dependency when we can utilize the standard library.

@ldez
Copy link
Member

ldez commented Nov 27, 2024

We don't need to minimize external dependencies.
This doesn't simplify the maintenance because this lib is stable.

And the reasons behind the usage of this lib are still relevant.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants