dev: refactor ifs with cmp.Or

[alexandear]

The PR refactors applicable if statements to use cmp.Or.

See https://blog.carlana.net/post/2024/golang-cmp-or-uses-and-history/

[ldez]

This is an abuse of cmp.Or: this function is mainly useful when creating a comparison implementation.
The readability and performance of cmp.Or are worse than simple if.

First, because this function iterates through a slice.

Secondly, cmp.Or requires the evaluation of all parts before comparing them whereas the if evaluates the first and the second only if needed, so this is mainly a bad idea to put this everywhere.

For example:

l.cfg.Run.Go = cmp.Or(l.cfg.Run.Go, detectGoVersion())

In this example, detectGoVersion() will be always called, but we don't want that because this call is costly.

With an if the function detectGoVersion() is only called if needed.

if l.cfg.Run.Go == "" {
    l.cfg.Run.Go = detectGoVersion()
}

So cmp.Or should be used only for values, and when this really improves the readability.

[ldez]

I hope the usage of cmp.Or will not be wrongly widespread over the Go ecosystem.

[ccoVeille]

I hope the usage of cmp.Or will not be wrongly widespread over the Go ecosystem.

Maybe it's time to build a new linter 🦸