importas: allow multiple empty aliases #5222
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ldez
added
enhancement
ldez
force-pushed
the
fix/importas-empty-aliases
branch
from
0c5be82 to
e190980
Compare
denisvmedia
reviewed
Dec 13, 2024
denisvmedia
reviewed
Dec 13, 2024
|
LGTM, thanks! I'm not sure about the tests, up to you. |
ldez
force-pushed
the
fix/importas-empty-aliases
branch
from
2d88a83 to
569025b
Compare
denisvmedia
reviewed
Dec 13, 2024
alexandear
approved these changes
Dec 13, 2024
This was referenced Dec 13, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The identical aliases are forbidden to avoid package conflicts but an empty alias is just a standard import so it's possible to have several ones.
It's less restrictive than the option
no-extra-aliases.Fixes #5221