Skip to content

Conversation

ldez
Copy link
Member

@ldez ldez commented Dec 13, 2024

The identical aliases are forbidden to avoid package conflicts but an empty alias is just a standard import so it's possible to have several ones.

It's less restrictive than the option no-extra-aliases.

Fixes #5221

@ldez ldez added enhancement New feature or improvement linter: update Update the linter implementation inside golangci-lint labels Dec 13, 2024
@ldez ldez added this to the next milestone Dec 13, 2024
@ldez ldez force-pushed the fix/importas-empty-aliases branch from 0c5be82 to e190980 Compare December 13, 2024 14:28
@denisvmedia
Copy link

LGTM, thanks! I'm not sure about the tests, up to you.

@ldez ldez force-pushed the fix/importas-empty-aliases branch from 2d88a83 to 569025b Compare December 13, 2024 15:02
@ldez ldez merged commit b2e24d6 into golangci:master Dec 13, 2024
15 checks passed
@ldez ldez deleted the fix/importas-empty-aliases branch December 13, 2024 17:13
@ldez ldez modified the milestones: next, v1.63 Jan 1, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

enhancement New feature or improvement linter: update Update the linter implementation inside golangci-lint

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants