feat: improve formatter messages #5243
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ldez
added
the
linter: update
ldez
force-pushed
the
fix/formatter-messages
branch
from
91ededf to
59b16cc
Compare
|
Good changes. The messages with gci-ed and gofumpt-ed confused some of my colleagues. |
alexandear
reviewed
Dec 23, 2024
alexandear
approved these changes
Dec 24, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The formaters are not classic linter, it makes no sense to use exclusions for them, so I think nobody (or at least very very few people) will be affected by this change.
IMHO, we don't need to create a v2 to change those messages.
Fixes #138