feat: disable timeout if timeout <= 0 #5250
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ldez
added
enhancement
ccoVeille
reviewed
Dec 24, 2024
bombsimon
approved these changes
Dec 24, 2024
ldez
force-pushed
the
fix/timeout-zero
branch
from
7ae79ff to
1b567b0
Compare
alexandear
reviewed
Dec 25, 2024
alexandear
approved these changes
Dec 25, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently, if the timeout is <=0, you have an immediate "context deadline exceeded".
This is useless, so now timeout <=0 means infinite timeout.
The default timeout is not changed.
Fixes #957