Skip to content

fix: invalid position when missing EOL #5279

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jan 2, 2025
Merged

fix: invalid position when missing EOL #5279

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion pkg/goanalysis/position.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -37,7 +37,7 @@ func GetFilePositionFor(fset *token.FileSet, p token.Pos) token.Position {
func EndOfLinePos(f *token.File, line int) token.Pos {
var end token.Pos

if line == f.LineCount() {
if line >= f.LineCount() {
// missing newline at the end of the file
end = f.Pos(f.Size())
} else {
Expand Down
2 changes: 1 addition & 1 deletion pkg/golinters/gofumpt/testdata/gofumpt.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -5,4 +5,4 @@ import "fmt"

func GofumptNewLine() {
fmt.Println( "foo" ) // want "File is not properly formatted"
}
} // want "File is not properly formatted"
Loading