dev: standardization of the integration of formatters #5301
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ldez
added
enhancement
ldez
force-pushed
the
feat/analyzer-formatter
branch
from
0879174 to
dbce1f6
Compare
|
This is wonderful! Is there a cli flag or something to run just the set of formatters prior to all other linters? While gci, gofumpt are 100% reliable, we have found that the suggested fixes for some linters are less reliable. We don't bother to review formatter fixes, but we do want a human to check suggested fixes from other linters. |
|
@StevenACoffman Take a look to #5296 |
ldez
changed the title
alexandear
reviewed
Jan 8, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This standardizes the integration of formatters.
Side effect:
github.com/golangci/gofmt/goimportsfrom the modulegithub.com/golangci/gofmtis removed 🎉diffbinary is not used anymore 🎉 🎉Closes #3408
Closes #362
Other issues related to the usage of
diff(on Windows):Related to #5296