feat: remove compatibility layer for formatters configuration #5446
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bombsimon
reviewed
Feb 19, 2025
There was a problem hiding this comment.
If a formatter is enabled inside formatters and linters, the configuration of formatters.settings will override linters-settings even if the configuration is omitted or empty inside formatters.settings section.
Should this be tested? Or even a case with config only present under linters?
|
This sentence was from the previous PR, now using linter settings is not allowed to define formatter settings.
It is tested by integration tests, but I will improve tests when I will add new linter configuration. |
bombsimon
approved these changes
Feb 19, 2025
alexandear
approved these changes
Feb 19, 2025
alexandear
reviewed
Feb 19, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Some other changes will be added when I will add the new linters configuration (#5299).
Follows #5357
Fixes #5296