Skip to content

dev: jsonschema support for revive comment directives #5448

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 4 commits into from
Feb 19, 2025
Merged

dev: jsonschema support for revive comment directives #5448

Show file tree
Hide file tree
Changes from 3 commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
bf16816
support comment directives for revive linter
urgas9 Feb 19, 2025
614dae7
Merge branch 'master' into revive-support-directives
urgas9 Feb 19, 2025
a77ee84
review
ldez Feb 19, 2025
95626e2
Apply suggestions from code review
urgas9 Feb 19, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 6 additions & 0 deletions .golangci.next.reference.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2386,6 +2386,12 @@ linters-settings:
# Default: false
enable-all-rules: true

# Enable validation of comment directives
# See https://github.com/mgechev/revive#comment-directives
directives:
- name: specify-disable-reason
severity: error

# Sets the default failure confidence.
# This means that linting errors with less than 0.8 confidence will be ignored.
# Default: 0.8
Expand Down
6 changes: 6 additions & 0 deletions .golangci.reference.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2386,6 +2386,12 @@ linters-settings:
# Default: false
enable-all-rules: true

# Enable validation of comment directives
# See https://github.com/mgechev/revive#comment-directives
directives:
- name: specify-disable-reason
severity: error

# Sets the default failure confidence.
# This means that linting errors with less than 0.8 confidence will be ignored.
# Default: 0.8
Expand Down
26 changes: 26 additions & 0 deletions jsonschema/golangci.jsonschema.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2657,6 +2657,32 @@
"type": "boolean",
"default": false
},
"directives": {
"type": "array",
"items": {
"type": "object",
"additionalProperties": false,
"properties": {
"name": {
"type": "string",
"enum": ["specify-disable-reason"]
},
"severity": {
"type": "string",
"enum": ["warning", "error"]
},
"exclude": {
"type": "array",
"items": {
"type": "string"
}
},
"arguments": {
"type": "array"
}
}
}
},
"rules": {
"type": "array",
"items": {
Expand Down
26 changes: 26 additions & 0 deletions jsonschema/golangci.next.jsonschema.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2657,6 +2657,32 @@
"type": "boolean",
"default": false
},
"directives": {
"type": "array",
"items": {
"type": "object",
"additionalProperties": false,
"properties": {
"name": {
"type": "string",
"enum": ["specify-disable-reason"]
},
"severity": {
"type": "string",
"enum": ["warning", "error"]
},
"exclude": {
"type": "array",
"items": {
"type": "string"
}
},
"arguments": {
"type": "array"
}
}
}
},
"rules": {
"type": "array",
"items": {
Expand Down
26 changes: 26 additions & 0 deletions jsonschema/golangci.v1.57.jsonschema.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2209,6 +2209,32 @@
"type": "boolean",
"default": false
},
"directives": {
"type": "array",
"items": {
"type": "object",
"additionalProperties": false,
"properties": {
"name": {
"type": "string",
"enum": ["specify-disable-reason"]
},
"severity": {
"type": "string",
"enum": ["warning", "error"]
},
"exclude": {
"type": "array",
"items": {
"type": "string"
}
},
"arguments": {
"type": "array"
}
}
}
},
"rules": {
"type": "array",
"items": {
Expand Down
26 changes: 26 additions & 0 deletions jsonschema/golangci.v1.58.jsonschema.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2380,6 +2380,32 @@
"type": "boolean",
"default": false
},
"directives": {
"type": "array",
"items": {
"type": "object",
"additionalProperties": false,
"properties": {
"name": {
"type": "string",
"enum": ["specify-disable-reason"]
},
"severity": {
"type": "string",
"enum": ["warning", "error"]
},
"exclude": {
"type": "array",
"items": {
"type": "string"
}
},
"arguments": {
"type": "array"
}
}
}
},
"rules": {
"type": "array",
"items": {
Expand Down
26 changes: 26 additions & 0 deletions jsonschema/golangci.v1.59.jsonschema.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2463,6 +2463,32 @@
"type": "boolean",
"default": false
},
"directives": {
"type": "array",
"items": {
"type": "object",
"additionalProperties": false,
"properties": {
"name": {
"type": "string",
"enum": ["specify-disable-reason"]
},
"severity": {
"type": "string",
"enum": ["warning", "error"]
},
"exclude": {
"type": "array",
"items": {
"type": "string"
}
},
"arguments": {
"type": "array"
}
}
}
},
"rules": {
"type": "array",
"items": {
Expand Down
26 changes: 26 additions & 0 deletions jsonschema/golangci.v1.60.jsonschema.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2469,6 +2469,32 @@
"type": "boolean",
"default": false
},
"directives": {
"type": "array",
"items": {
"type": "object",
"additionalProperties": false,
"properties": {
"name": {
"type": "string",
"enum": ["specify-disable-reason"]
},
"severity": {
"type": "string",
"enum": ["warning", "error"]
},
"exclude": {
"type": "array",
"items": {
"type": "string"
}
},
"arguments": {
"type": "array"
}
}
}
},
"rules": {
"type": "array",
"items": {
Expand Down
26 changes: 26 additions & 0 deletions jsonschema/golangci.v1.61.jsonschema.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2474,6 +2474,32 @@
"type": "boolean",
"default": false
},
"directives": {
"type": "array",
"items": {
"type": "object",
"additionalProperties": false,
"properties": {
"name": {
"type": "string",
"enum": ["specify-disable-reason"]
},
"severity": {
"type": "string",
"enum": ["warning", "error"]
},
"exclude": {
"type": "array",
"items": {
"type": "string"
}
},
"arguments": {
"type": "array"
}
}
}
},
"rules": {
"type": "array",
"items": {
Expand Down
26 changes: 26 additions & 0 deletions jsonschema/golangci.v1.62.jsonschema.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2528,6 +2528,32 @@
"type": "boolean",
"default": false
},
"directives": {
"type": "array",
"items": {
"type": "object",
"additionalProperties": false,
"properties": {
"name": {
"type": "string",
"enum": ["specify-disable-reason"]
},
"severity": {
"type": "string",
"enum": ["warning", "error"]
},
"exclude": {
"type": "array",
"items": {
"type": "string"
}
},
"arguments": {
"type": "array"
}
}
}
},
"rules": {
"type": "array",
"items": {
Expand Down
26 changes: 26 additions & 0 deletions jsonschema/golangci.v1.63.jsonschema.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2606,6 +2606,32 @@
"type": "boolean",
"default": false
},
"directives": {
"type": "array",
"items": {
"type": "object",
"additionalProperties": false,
"properties": {
"name": {
"type": "string",
"enum": ["specify-disable-reason"]
},
"severity": {
"type": "string",
"enum": ["warning", "error"]
},
"exclude": {
"type": "array",
"items": {
"type": "string"
}
},
"arguments": {
"type": "array"
}
}
}
},
"rules": {
"type": "array",
"items": {
Expand Down
Loading