Skip to content

dev: fix schema not accepting valid timeout #5501

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Mar 3, 2025
Merged

dev: fix schema not accepting valid timeout #5501

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
7c42f3a
Fix schema not accepting valid time.Duration format
SuperSandro2000 Mar 3, 2025
31f5127
review
ldez Mar 3, 2025
4abd55d
review
ldez Mar 3, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion .golangci.next.reference.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4159,7 +4159,7 @@ output:

# Options for analysis running.
run:
# Timeout for analysis, e.g. 30s, 5m.
# Timeout for analysis, e.g. 30s, 5m, 5m30s.
# If the value is lower or equal to 0, the timeout is disabled.
# Default: 1m
timeout: 5m
Expand Down
2 changes: 1 addition & 1 deletion .golangci.reference.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4159,7 +4159,7 @@ output:

# Options for analysis running.
run:
# Timeout for analysis, e.g. 30s, 5m.
# Timeout for analysis, e.g. 30s, 5m, 5m30s.
# If the value is lower or equal to 0, the timeout is disabled.
# Default: 1m
timeout: 5m
Expand Down
4 changes: 2 additions & 2 deletions jsonschema/golangci.jsonschema.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -472,9 +472,9 @@
"timeout": {
"description": "Timeout for the analysis.",
"type": "string",
"pattern": "^\\d*[sm]$",
"pattern": "^(\\d*m)?\\d*[sm]$",
"default": "1m",
"examples": ["30s", "5m"]
"examples": ["30s", "5m", "5m30s"]
},
"issues-exit-code": {
"description": "Exit code when at least one issue was found.",
Expand Down
4 changes: 2 additions & 2 deletions jsonschema/golangci.next.jsonschema.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -472,9 +472,9 @@
"timeout": {
"description": "Timeout for the analysis.",
"type": "string",
"pattern": "^\\d*[sm]$",
"pattern": "^(\\d*m)?\\d*[sm]$",
"default": "1m",
"examples": ["30s", "5m"]
"examples": ["30s", "5m", "5m30s"]
},
"issues-exit-code": {
"description": "Exit code when at least one issue was found.",
Expand Down
4 changes: 2 additions & 2 deletions jsonschema/golangci.v1.57.jsonschema.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -351,9 +351,9 @@
"timeout": {
"description": "Timeout for the analysis.",
"type": "string",
"pattern": "^\\d*[sm]$",
"pattern": "^(\\d*m)?\\d*[sm]$",
"default": "1m",
"examples": ["30s", "5m"]
"examples": ["30s", "5m", "5m30s"]
},
"issues-exit-code": {
"description": "Exit code when at least one issue was found.",
Expand Down
4 changes: 2 additions & 2 deletions jsonschema/golangci.v1.58.jsonschema.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -353,9 +353,9 @@
"timeout": {
"description": "Timeout for the analysis.",
"type": "string",
"pattern": "^\\d*[sm]$",
"pattern": "^(\\d*m)?\\d*[sm]$",
"default": "1m",
"examples": ["30s", "5m"]
"examples": ["30s", "5m", "5m30s"]
},
"issues-exit-code": {
"description": "Exit code when at least one issue was found.",
Expand Down
4 changes: 2 additions & 2 deletions jsonschema/golangci.v1.59.jsonschema.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -435,9 +435,9 @@
"timeout": {
"description": "Timeout for the analysis.",
"type": "string",
"pattern": "^\\d*[sm]$",
"pattern": "^(\\d*m)?\\d*[sm]$",
"default": "1m",
"examples": ["30s", "5m"]
"examples": ["30s", "5m", "5m30s"]
},
"issues-exit-code": {
"description": "Exit code when at least one issue was found.",
Expand Down
4 changes: 2 additions & 2 deletions jsonschema/golangci.v1.60.jsonschema.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -441,9 +441,9 @@
"timeout": {
"description": "Timeout for the analysis.",
"type": "string",
"pattern": "^\\d*[sm]$",
"pattern": "^(\\d*m)?\\d*[sm]$",
"default": "1m",
"examples": ["30s", "5m"]
"examples": ["30s", "5m", "5m30s"]
},
"issues-exit-code": {
"description": "Exit code when at least one issue was found.",
Expand Down
4 changes: 2 additions & 2 deletions jsonschema/golangci.v1.61.jsonschema.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -440,9 +440,9 @@
"timeout": {
"description": "Timeout for the analysis.",
"type": "string",
"pattern": "^\\d*[sm]$",
"pattern": "^(\\d*m)?\\d*[sm]$",
"default": "1m",
"examples": ["30s", "5m"]
"examples": ["30s", "5m", "5m30s"]
},
"issues-exit-code": {
"description": "Exit code when at least one issue was found.",
Expand Down
4 changes: 2 additions & 2 deletions jsonschema/golangci.v1.62.jsonschema.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -442,9 +442,9 @@
"timeout": {
"description": "Timeout for the analysis.",
"type": "string",
"pattern": "^\\d*[sm]$",
"pattern": "^(\\d*m)?\\d*[sm]$",
"default": "1m",
"examples": ["30s", "5m"]
"examples": ["30s", "5m", "5m30s"]
},
"issues-exit-code": {
"description": "Exit code when at least one issue was found.",
Expand Down
4 changes: 2 additions & 2 deletions jsonschema/golangci.v1.63.jsonschema.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -463,9 +463,9 @@
"timeout": {
"description": "Timeout for the analysis.",
"type": "string",
"pattern": "^\\d*[sm]$",
"pattern": "^(\\d*m)?\\d*[sm]$",
"default": "1m",
"examples": ["30s", "5m"]
"examples": ["30s", "5m", "5m30s"]
},
"issues-exit-code": {
"description": "Exit code when at least one issue was found.",
Expand Down
Loading