Skip to content

feat: drop v1 compatibility with exclude-dirs-use-default for fmt #5520

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Mar 10, 2025
Merged

feat: drop v1 compatibility with exclude-dirs-use-default for fmt #5520

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
036e53e
chore(fmt): drop v1 compatibility with exclude-dirs-use-default
ldez Mar 10, 2025
288948a
tests: update migration tests
ldez Mar 10, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion pkg/commands/internal/migrate/migrate_formatters.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -18,7 +18,7 @@ func toFormatters(old *versionone.Config) versiontwo.Formatters {
}

if old.Issues.UseDefaultExcludeDirs == nil || ptr.Deref(old.Issues.UseDefaultExcludeDirs) {
paths = append(paths, "examples$")
paths = append(paths, "third_party$", "builtin$", "examples$")
}

paths = append(paths, toFormattersPathsFromRules(old.Issues)...)
Expand Down
2 changes: 2 additions & 0 deletions pkg/commands/internal/migrate/testdata/json/empty.golden.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3,6 +3,8 @@
"exclusions": {
"generated": "lax",
"paths": [
"third_party$",
"builtin$",
"examples$"
]
}
Expand Down
2 changes: 2 additions & 0 deletions pkg/commands/internal/migrate/testdata/toml/empty.golden.toml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -19,5 +19,7 @@ paths = [
[formatters.exclusions]
generated = 'lax'
paths = [
'third_party$',
'builtin$',
'examples$'
]
2 changes: 2 additions & 0 deletions pkg/commands/internal/migrate/testdata/yaml/empty.golden.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -15,4 +15,6 @@ formatters:
exclusions:
generated: lax
paths:
- third_party$
- builtin$
- examples$
2 changes: 2 additions & 0 deletions pkg/commands/internal/migrate/testdata/yaml/issues_07_a.golden.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -8,4 +8,6 @@ linters:
formatters:
exclusions:
paths:
- third_party$
- builtin$
- examples$
2 changes: 2 additions & 0 deletions pkg/commands/internal/migrate/testdata/yaml/issues_07_b.golden.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -11,4 +11,6 @@ formatters:
- goimports
exclusions:
paths:
- third_party$
- builtin$
- examples$
2 changes: 2 additions & 0 deletions pkg/commands/internal/migrate/testdata/yaml/unknown-fields.golden.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -15,4 +15,6 @@ formatters:
exclusions:
generated: lax
paths:
- third_party$
- builtin$
- examples$
3 changes: 0 additions & 3 deletions pkg/goformat/runner.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -194,9 +194,6 @@ func skipDir(name string) bool {
case "vendor", "testdata", "node_modules":
return true

case "third_party", "builtin": // For compatibility with `exclude-dirs-use-default`.
return true

default:
return strings.HasPrefix(name, ".")
}
Expand Down
Loading