perf: nolint simplifications and improvements #5847
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
As we are using a regex anyway for the initial pass, make use of capture groups in it, instead of running the text through another regex and a round of separate string parses.
scop
changed the title
|
nolint code is considered frozen. |
|
That sounds odd to me. Anyway, just to make sure it did not go unnoticed, this PR contains changes to both nolint code, as well as nolintlint code. Are both frozen, or is the nolintlint change acceptable if I removed the nolint commit? Reopening for comments. |
|
They are both frozen because it's the same topic. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See individual comments for details.
I have not run actual benchmarks on these exact changes, but from experience I expect them to show some performance and memory use improvements, in addition to the code being simpler.