Skip to content
Closed
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
41 changes: 40 additions & 1 deletion pkg/goanalysis/runner_loadingpackage.go
Original file line number Diff line number Diff line change
Expand Up @@ -239,9 +239,11 @@ func (lp *loadingPackage) loadFromExportData() error {
return fmt.Errorf("dependency %q hasn't been loaded yet", path)
}
}

if pkg.ExportFile == "" {
return fmt.Errorf("no export data for %q", pkg.ID)
return noExportDataError(pkg)
}

f, err := os.Open(pkg.ExportFile)
if err != nil {
return err
Expand Down Expand Up @@ -332,6 +334,7 @@ func (lp *loadingPackage) loadImportedPackageWithFacts(loadMode LoadMode) error
if srcErr := lp.loadFromSource(loadMode); srcErr != nil {
return srcErr
}

// Make sure this package can't be imported successfully
pkg.Errors = append(pkg.Errors, packages.Error{
Pos: "-",
Expand Down Expand Up @@ -553,3 +556,39 @@ func sizeOfReflectValueTreeBytes(rv reflect.Value, visitedPtrs map[uintptr]struc
panic("unknown rv of type " + rv.String())
}
}

func noExportDataError(pkg *packages.Package) error {
seen := make(map[string]struct{})

const limit = 3

var count int

var sb strings.Builder

packages.Visit([]*packages.Package{pkg}, func(p *packages.Package) bool {
if count >= limit {
return false
}

if _, ok := seen[p.ID]; ok {
return false
}

seen[p.ID] = struct{}{}

for _, e := range p.Errors {
fmt.Fprintf(&sb, "\terror in package %q: %s\n", p.ID, e.Msg)
count++
}

return true
}, nil)

msg := fmt.Sprintf("no export data for %q", pkg.ID)
if sb.Len() > 0 {
msg += fmt.Sprintf(", maybe because of error(s) in imported package(s):\n%s", sb.String())
}

return errors.New(msg)
}