pkg/goanalysis: add better error message for 'no export data' failure #6059
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
If compilation or building of a Go package fails, export data will not be available. Previously, we would mask the underlying failure and display only a message that "no export data" was available. This has led to lots of confusion among golangci-lint users (and users at my company, which is how I discovered this problem). golangci#3996 golangci#4630 golangci#4912 golangci#4964 golangci#5037 golangci#5051 golangci#5184 golangci#5428 golangci#5437 In addition to numerous discussions. The only common thread between the responses to these discussions, is that the "no export data" error message is obscuring whatever the underlying problem is, and making it more difficult to troubleshoot. golangci#2489 golangci#2191 golangci#2751 golangci#3363 golangci#4829 golangci#4880 This fix indicates to users what they should try next if they receive this error message from golangci-lint. Hopefully, this will help users solve their own problem, and reduce the amount of issues and discussions related to this issue that people post on the discussion boards.
|
By creating the PR after I closed #6058, what was your expectation? |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If compilation or building of a Go package fails, export data will not be available. Previously, we would mask the underlying failure and display only a message that "no export data" was available. This has led to lots of confusion among golangci-lint users (and users at my company, which is how I discovered this problem).
#3996
#4630
#4912
#4964
#5037
#5051
#5184
#5428
#5437
In addition to numerous discussions. The only common thread between the responses to these discussions, is that the "no export data" error message is obscuring whatever the underlying problem is, and making it more difficult to troubleshoot.
#2489
#2191
#2751
#3363
#4829
#4880
This fix indicates to users what they should try next if they receive this error message from golangci-lint. Hopefully, this will help users solve their own problem, and reduce the amount of issues and discussions related to this issue that people post on the discussion boards.