Skip to content
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions go.mod
Original file line number Diff line number Diff line change
Expand Up @@ -55,13 +55,13 @@ require (
github.com/golangci/gofmt v0.0.0-20250106114630-d62b90e6713d
github.com/golangci/golines v0.0.0-20250217134842-442fd0091d95
github.com/golangci/misspell v0.7.0
github.com/golangci/nilerr v0.0.0-20250918000102-015671e622fe
github.com/golangci/plugin-module-register v0.1.2
github.com/golangci/revgrep v0.8.0
github.com/golangci/swaggoswag v0.0.0-20250504205917-77f2aca3143e
github.com/golangci/unconvert v0.0.0-20250410112200-a129a6e6413e
github.com/gordonklaus/ineffassign v0.2.0
github.com/gostaticanalysis/forcetypeassert v0.2.0
github.com/gostaticanalysis/nilerr v0.1.1
github.com/hashicorp/go-version v1.7.0
github.com/jgautheron/goconst v1.8.2
github.com/jingyugao/rowserrcheck v1.1.1
Expand Down Expand Up @@ -218,7 +218,7 @@ require (
go.uber.org/zap v1.27.0 // indirect
golang.org/x/exp v0.0.0-20240909161429-701f63a606c0 // indirect
golang.org/x/exp/typeparams v0.0.0-20250911091902-df9299821621 // indirect
golang.org/x/text v0.28.0 // indirect
golang.org/x/text v0.29.0 // indirect
golang.org/x/tools/go/expect v0.1.1-deprecated // indirect
golang.org/x/tools/go/packages/packagestest v0.1.1-deprecated // indirect
google.golang.org/protobuf v1.36.6 // indirect
Expand Down
11 changes: 4 additions & 7 deletions go.sum

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

2 changes: 1 addition & 1 deletion pkg/golinters/nilerr/nilerr.go
Original file line number Diff line number Diff line change
@@ -1,7 +1,7 @@
package nilerr

import (
"github.com/gostaticanalysis/nilerr"
"github.com/golangci/nilerr"

"github.com/golangci/golangci-lint/v2/pkg/goanalysis"
)
Expand Down
26 changes: 26 additions & 0 deletions pkg/golinters/nilerr/testdata/nilerr.go
Original file line number Diff line number Diff line change
Expand Up @@ -33,3 +33,29 @@ func nilErr3() error {
func nilErrDo() error {
return os.ErrNotExist
}

func l() error {
aChan := make(chan error, 1)
bChan := make(chan error, 1)

var aErr error
var bErr error

for i := 0; i < 2; i++ {
select {
case err := <-aChan:
aErr = err
case err := <-bChan:
bErr = err
}
}

if aErr != nil {
return nil // want `error is not nil \(lines \[41 45\]\) but it returns nil`
}
if bErr != nil {
return nil // want `error is not nil \(lines \[42 45\]\) but it returns nil`
}

return nil
}
Loading