Feat/mcp serve cli #2596
Open
Feat/mcp serve cli #2596
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Implements issue golemcloud#1926 - MCP Server for Golem CLI - Add --serve and --serve-port flags to enable MCP server mode - Expose all CLI leaf commands as MCP tools - Expose golem.yaml manifests as MCP resources - Use rmcp crate with HTTP Streamable transport - Add E2E tests for MCP functionality - Update README with MCP usage documentation
There was a problem hiding this comment.
Pull request overview
This PR implements MCP (Model Context Protocol) server functionality for the Golem CLI, enabling AI agents to interact with Golem programmatically through HTTP-based JSON-RPC communication.
Changes:
- Added new
mcpmodule exposing CLI commands as MCP tools and golem.yaml manifests as MCP resources - Added comprehensive E2E tests for MCP server functionality
- Updated dependencies to include
rmcpandaxumcrates - Added MCP usage documentation to README
Reviewed changes
Copilot reviewed 5 out of 5 changed files in this pull request and generated 6 comments.
Show a summary per file
| File | Description |
|---|---|
| cli/golem-cli/src/mcp.rs | New MCP server implementation exposing CLI commands as tools and manifests as resources |
| cli/golem-cli/tests/mcp_e2e.rs | Comprehensive E2E tests for MCP server functionality |
| cli/golem-cli/src/lib.rs | Added mcp module to public exports |
| cli/golem-cli/Cargo.toml | Added rmcp and axum dependencies |
| README.md | Added MCP server mode documentation with usage examples |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
|
|
||
| let result = client | ||
| .call_tool(name, serde_json::json!({"args": ["--help"]})) | ||
| .expect(&format!("Failed to call tool: {}", name)); |
There was a problem hiding this comment.
Using expect with a formatted string is inefficient because the string is allocated even when the Result is Ok. Replace with unwrap_or_else or use expect with a static string and include the error context in the panic message using the error's Display implementation.
Co-authored-by: Copilot <[email protected]>
Co-authored-by: Copilot <[email protected]>
Co-authored-by: Copilot <[email protected]>
Co-authored-by: Copilot <[email protected]>
Co-authored-by: Copilot <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Implements #1926 - MCP Server for Golem CLI
This PR adds an MCP (Model Context Protocol) server mode to the Golem CLI, enabling AI agents and tools to interact with Golem programmatically.
Changes
--serveand--serve-portflags to enable MCP server modegolem.yamlmanifests as MCP resourcesrmcpcrate with HTTP Streamable transportUsage