sdks/ts: enforce no-explicit-any and replace any with proper types

cli/desktop-app/.gitignore

@@ -1,5 +1,6 @@
 # Logs
 logs
+storybook-static
 *.log
 npm-debug.log*
 yarn-debug.log*

cli/golem-cli/ts_bridge/base.ts

@@ -7,8 +7,9 @@ export type GolemServer =
 
 export type AroundInvokeHook = {
     beforeInvoke: (request: AgentInvocationRequest) => Promise<void>;
-    afterInvoke: (request: AgentInvocationRequest, result: JsonResult<AgentInvocationResult, any>) => Promise<void>;
-};
+        afterInvoke: (request: AgentInvocationRequest, result: JsonResult<AgentInvocationResult, unknown>) => Promise<void>;
+    }
+    ;
 
 export type Configuration = {
     server: GolemServer,

sdks/ts/packages/golem-ts-repl/eslint.config.mjs

@@ -26,6 +26,7 @@ export default [
       'no-dupe-keys': 'error',
       'no-duplicate-case': 'error',
       eqeqeq: ['error', 'always'],
+      '@typescript-eslint/no-explicit-any': 'error',
       '@typescript-eslint/no-floating-promises': 'error',
       '@typescript-eslint/no-misused-promises': 'error',
     },

sdks/ts/packages/golem-ts-repl/src/base.ts

@@ -25,7 +25,7 @@ export type AroundInvokeHook = {
   beforeInvoke: (request: AgentInvocationRequest) => Promise<void>;
   afterInvoke: (
     request: AgentInvocationRequest,
-    result: JsonResult<AgentInvocationResult, any>,
+    result: JsonResult<AgentInvocationResult, unknown>,
   ) => Promise<void>;
 };
 
@@ -41,6 +41,52 @@ export type EnvironmentName = string;
 export type AgentTypeName = string;
 export type IdempotencyKey = string;
 
+export type Timestamp = string; // ISO 8601
+
+export type WorkerStatus =
+  | 'Running'
+  | 'Idle'
+  | 'Suspended'
+  | 'Interrupted'
+  | 'Retrying'
+  | 'Failed'
+  | 'Exited';
+
+export type UpdateRecord =
+  | { type: 'PendingUpdate'; timestamp: Timestamp; targetRevision: number }
+  | { type: 'SuccessfulUpdate'; timestamp: Timestamp; targetRevision: number }
+  | {
+      type: 'FailedUpdate';
+      timestamp: Timestamp;
+      targetRevision: number;
+      details?: string;
+    };
+
+export type WorkerResourceDescription = {
+  createdAt: Timestamp;
+  resourceOwner: string;
+  resourceName: string;
+};
+
+export type Worker = {
+  componentName: string;
+  workerName: string;
+  createdBy: string;
+  environmentId: string;
+  env: Record<string, string>;
+  configVars: Record<string, string>;
+  status: WorkerStatus;
+  componentRevision: number;
+  retryCount: number;
+  pendingInvocationCount: number;
+  updates: UpdateRecord[];
+  createdAt: Timestamp;
+  lastError?: string;
+  componentSize: number;
+  totalLinearMemorySize: number;
+  exportedResourceInstances: Record<string, WorkerResourceDescription>;
+};
+
 export type DataValue =
   | { type: 'Tuple'; elements: ElementValue[] }
   | { type: 'Multimodal'; elements: NamedElementValue[] };

sdks/ts/packages/golem-ts-repl/src/cli-repl-interop.ts

@@ -13,12 +13,14 @@
 // limitations under the License.
 
 import childProcess, { ChildProcess } from 'node:child_process';
+import { Buffer } from 'buffer';
 import repl from 'node:repl';
 import pc from 'picocolors';
 import { CliArgMetadata, CliCommandMetadata, CliCommandsConfig } from './config';
 import { flushStdIO, writeChunk } from './process';
 import { writeFullLineSeparator } from './format';
 import * as base from './base';
+import { Worker } from './base';
 import * as uuid from 'uuid';
 
 const AGENT_STREAM_CLOSE_DELAY_MS = 100;
@@ -335,14 +337,15 @@ const COMPLETION_HOOKS: Partial<Record<CompletionHookId, CompletionHook>> = {
   AGENT_ID: {
     complete: async (cli, currentToken) => {
       const result = await cli.runJson({ args: ['agent', 'list'] });
+      const json = result.json as { workers?: Partial<Worker>[] };
 
-      if (!result.ok || !result.json || !Array.isArray(result.json.workers)) {
+      if (!result.ok || !json || !Array.isArray(json.workers)) {
         return [];
       }
 
-      const values = result.json.workers
-        .map((worker: any) => worker.workerName)
-        .filter((value: unknown): value is string => typeof value === 'string');
+      const values = json.workers
+        .map((worker) => worker.workerName)
+        .filter((value): value is string => typeof value === 'string');
 
       return filterByPrefix(values, currentToken);
     },
@@ -355,12 +358,13 @@ const COMPLETION_HOOKS: Partial<Record<CompletionHookId, CompletionHook>> = {
         return [];
       }
 
-      if (!result.json || !Array.isArray(result.json)) {
+      const json = result.json as { componentName: string }[];
+      if (!json || !Array.isArray(json)) {
         return [];
       }
 
-      const values = result.json
-        .map((component: any) => component?.componentName)
+      const values = json
+        .map((component) => component?.componentName)
         .filter((value: unknown): value is string => typeof value === 'string');
 
       return filterByPrefix(values, currentToken);
@@ -415,11 +419,11 @@ class GolemCli {
       let stderr = '';
 
       if (opts.mode === 'collect') {
-        child.stdout?.on('data', (chunk) => {
+        child.stdout?.on('data', (chunk: Buffer) => {
           stdout += chunk.toString();
         });
 
-        child.stderr?.on('data', (chunk) => {
+        child.stderr?.on('data', (chunk: Buffer) => {
           stderr += chunk.toString();
         });
       }
@@ -432,7 +436,7 @@ class GolemCli {
 
   async runJson(opts: {
     args: string[];
-  }): Promise<{ ok: boolean; code: number | null; json: any }> {
+  }): Promise<{ ok: boolean; code: number | null; json: unknown }> {
     const result = await this.run({ args: ['--format', 'json', ...opts.args], mode: 'collect' });
     return { ok: result.ok, code: result.code, json: JSON.parse(result.stdout) };
   }

sdks/ts/packages/golem-ts-repl/src/config.ts

@@ -33,10 +33,14 @@ export type ReplCliFlags = {
   streamLogs: boolean;
 };
 
-export type AgentConfig = {
+export type AgentModule = Record<string, unknown> & {
+  configure: ConfigureClient;
+};
+
+export type AgentConfig<T extends AgentModule = AgentModule> = {
   clientPackageName: string;
   clientPackageImportedName: string;
-  package: any;
+  package: T;
 };
 
 export type ConfigureClient = (config: base.Configuration) => void;

sdks/ts/packages/golem-ts-repl/src/language-service.ts

@@ -668,8 +668,11 @@ function getFallbackArgumentInfo(
 function getResolvedSignature(
   callExpression: tsm.CallExpression | tsm.NewExpression,
 ): tsm.Signature | undefined {
-  const directSignature = (callExpression as any).getSignature?.();
-  if (directSignature) return directSignature;
+  const signature = callExpression
+    .getProject()
+    .getTypeChecker()
+    .getResolvedSignature(callExpression);
+  if (signature) return signature;
 
   const isNew = callExpression.getKind() === tsm.SyntaxKind.NewExpression;
   const expressionType = callExpression.getExpression().getType();

sdks/ts/packages/golem-ts-repl/src/repl.ts

@@ -16,7 +16,6 @@ import {
   cliCommandsConfigFromBaseConfig,
   clientConfigFromEnv,
   Config,
-  ConfigureClient,
   loadReplCliFlags,
   ReplCliFlags,
 } from './config';
@@ -25,13 +24,13 @@ import { LanguageService } from './language-service';
 import pc from 'picocolors';
 import repl, { type REPLEval } from 'node:repl';
 import process from 'node:process';
-import { AsyncCompleter } from 'readline';
+import { Completer, AsyncCompleter } from 'readline';
 import { PassThrough } from 'node:stream';
 import { ts } from 'ts-morph';
 import { flushStdIO, setOutput, writeln } from './process';
 import { formatAsTable, formatEvalError, logSnippetInfo } from './format';
 import * as base from './base';
-import { AgentInvocationRequest, AgentInvocationResult, JsonResult } from './base';
+import { AgentInvocationRequest } from './base';
 
 const MAX_COMPLETION_ENTRIES = 50;
 
@@ -61,11 +60,7 @@ export class Repl {
         }
       },
 
-      async afterInvoke(
-        request: AgentInvocationRequest,
-        result: JsonResult<AgentInvocationResult, any>,
-      ): Promise<void> {
-        void result;
+      async afterInvoke(request: AgentInvocationRequest): Promise<void> {
         await cli.stopAgentStream(request);
       },
     };
@@ -80,11 +75,13 @@ export class Repl {
 
   private newBaseReplServer(options?: {
     input?: NodeJS.ReadableStream;
-    output?: NodeJS.WritableStream;
+    output?: NodeJS.WriteStream;
     terminal?: boolean;
+    eval?: REPLEval;
+    completer?: Completer | AsyncCompleter;
   }): repl.REPLServer {
     const output = options?.output ?? process.stdout;
-    const terminal = options?.terminal ?? Boolean((output as any).isTTY);
+    const terminal = options?.terminal ?? Boolean(output.isTTY);
     const prompt = this.replCliFlags.script
       ? ''
       : `${pc.cyan('golem-ts-repl')}` +
@@ -101,13 +98,13 @@ export class Repl {
       preview: false,
       ignoreUndefined: true,
       prompt,
+      eval: options?.eval,
+      completer: options?.completer,
     });
   }
 
   private async setupRepl(replServer: repl.REPLServer): Promise<void> {
     await this.setupReplHistory(replServer);
-    this.setupReplEval(replServer);
-    this.setupReplCompleter(replServer);
     this.setupReplContext(replServer);
     this.setupReplCommands(replServer);
   }
@@ -124,13 +121,12 @@ export class Repl {
     });
   }
 
-  private setupReplEval(replServer: repl.REPLServer): repl.REPLEval {
-    const tsxEval = replServer.eval;
+  private createCustomEval(tsxEval: REPLEval): REPLEval {
     const languageService = this.getLanguageService();
     const replCliFlags = this.replCliFlags;
     const getOverrideSnippet = () => this.overrideSnippetForNextEval;
 
-    const customEval: REPLEval = function (code, context, filename, callback) {
+    return function (this: repl.REPLServer, code, context, filename, callback) {
       const evalCode = (code: string) => {
         tsxEval.call(this, code, context, filename, (err, result) => {
           if (!err) {
@@ -179,16 +175,12 @@ export class Repl {
         callback(null, undefined);
       }
     };
-    (replServer.eval as any) = customEval;
-
-    return tsxEval;
   }
 
-  private setupReplCompleter(replServer: repl.REPLServer) {
-    const nodeCompleter = replServer.completer;
+  private createCustomCompleter(nodeCompleter: Completer | AsyncCompleter): AsyncCompleter {
     const languageService = this.getLanguageService();
     const cli = this.cli;
-    const customCompleter: AsyncCompleter = function (line, callback) {
+    return function (line, callback) {
       if (line.trimStart().startsWith('.')) {
         cli
           .complete(line)
@@ -216,7 +208,6 @@ export class Repl {
         }
       }
     };
-    (replServer.completer as any) = customCompleter;
   }
 
   private setupReplContext(replServer: repl.REPLServer) {
@@ -227,7 +218,7 @@ export class Repl {
     const context = replServer.context;
     for (let agentTypeName in this.config.agents) {
       const agentConfig = this.config.agents[agentTypeName];
-      let configure = agentConfig.package.configure as ConfigureClient;
+      let configure = agentConfig.package.configure;
       configure(this.clientConfig);
       context[agentTypeName] = agentConfig.package[agentTypeName];
       context[agentConfig.clientPackageImportedName] = agentConfig.package;
@@ -346,13 +337,25 @@ export class Repl {
     setOutput('stdout');
 
     const script = this.replCliFlags.script;
+
+    // We need to create a temporary repl server to get the default eval and completer
+    const tempRepl = repl.start({ input: new PassThrough(), output: new PassThrough() });
+    const customEval = this.createCustomEval(tempRepl.eval);
+    const customCompleter = this.createCustomCompleter(tempRepl.completer);
+    tempRepl.close();
+
     const replServer = script
       ? this.newBaseReplServer({
           input: new PassThrough(),
           output: process.stdout,
           terminal: false,
+          eval: customEval,
+          completer: customCompleter,
         })
-      : this.newBaseReplServer();
+      : this.newBaseReplServer({
+          eval: customEval,
+          completer: customCompleter,
+        });
 
     await this.setupRepl(replServer);
 

sdks/ts/packages/golem-ts-sdk/eslint.config.mjs

@@ -28,6 +28,7 @@ export default [
       'no-dupe-keys': 'error',
       'no-duplicate-case': 'error',
       eqeqeq: ['error', 'always'],
+      '@typescript-eslint/no-explicit-any': 'error',
       '@typescript-eslint/no-floating-promises': 'error',
       '@typescript-eslint/no-misused-promises': 'error',
     },