Merged
Conversation
noise64
reviewed
Mar 2, 2026
| /// causing premature drop, the Weak becoming un-upgradeable, cache eviction, | ||
| /// and creation of a **second** oplog instance for the same worker. Two instances | ||
| /// means two independent `last_committed_idx` counters, leading to duplicate | ||
| /// INSERT attempts and a unique key violation in SQLite. |
noise64
approved these changes
Mar 2, 2026
noise64
approved these changes
Mar 3, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Trying to stabilize the integration tests
Cachetype and adds lot of tests to itHttpWorkerLogEventStreamthat I've seen causing stack overflowinitializeto make it impossible to double-initialize (even if some more race condition is not fixed yet)