Renames to improve code consistency#2867
Merged
vigoo merged 4 commits intoagent-types-changes-step1-step2from Mar 9, 2026
Merged
Renames to improve code consistency#2867vigoo merged 4 commits intoagent-types-changes-step1-step2from
vigoo merged 4 commits intoagent-types-changes-step1-step2from
Conversation
mschuwalow
approved these changes
Mar 9, 2026
| @@ -779,31 +778,31 @@ impl WorkerApi { | |||
| /// | |||
| /// The plugin must be one of the installed plugins for the worker's current component version. | |||
| #[oai( | |||
| path = "/:component_id/workers/:worker_name/activate-plugin", | |||
| path = "/:component_id/workers/:agent_name/activate-plugin", | |||
Contributor
There was a problem hiding this comment.
let's also rename these to
/:component_id/agents/:agent_name/activate-plugin
in a followup
* Normalized SDK metadata to native naming * Prepared helper macros for further tests * Agent types changes step 5 (last) (#2945) * New AgentId format and language-specific rendering, cleanups * More cleanups and tests * Benchmark * Compilation fixes * Unit tests passing * Test adjustments * Fixes * CLI improvements * CLI fixes * cli test fixes * Cleanup * Format * Fixes * analysing ci failures skill * Fix * Add migration 006 to drop agent_wrapper_type_name column Amp-Thread-ID: https://ampcode.com/threads/T-019cc47e-a88c-73f6-86e8-678b8e506697 Co-authored-by: Amp <amp@ampcode.com> * Fixes * Fixes * Eliminated some test-code redundancy * Review feedback --------- Co-authored-by: Amp <amp@ampcode.com> --------- Co-authored-by: Amp <amp@ampcode.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Step 3 of #2835
Improve consistency between WIT and Rust namings, and converge towards our new "agentic" namings.
Most importantly:
WorkerId → AgentIdOwnedWorkerId → OwnedAgentIdAgentId → ParsedAgentIdSome follow-up renamings (some of them were already inconsistent with its WIT counterparts, and the
WorkerId->AgentId:WorkerStatus → AgentStatusWorkerStatusRecord → AgentStatusRecordWorkerFilter → AgentFilter(+ all variants: WorkerNameFilter → AgentNameFilter, etc.)WorkerMetadata → AgentMetadata,WorkerMetadataDto → AgentMetadataDtoWorkerCreationRequest → AgentCreationRequestWorkerUpdateMode → AgentUpdateModeWorkerResourceDescription → AgentResourceDescriptionWorkerInvocation → AgentInvocation,WorkerInvocationPayload → AgentInvocationPayload,WorkerInvocationResult → AgentInvocationResult,WorkerInvocationOutput → AgentInvocationOutputWorkerConfig → AgentConfigWorkerExecutorErrorvariants renamed (WorkerNotFound → AgentNotFound, etc.)Breaks the HTTP API, but I think this is a right time to do so (as we already broke it by removing the old invocation endpoints)