Agent types changes step 4#2869
Merged
vigoo merged 5 commits intoagent-types-changes-step3from Mar 9, 2026
Merged
Conversation
mschuwalow
approved these changes
Mar 9, 2026
Contributor
mschuwalow
left a comment
mschuwalow
left a comment
There was a problem hiding this comment.
There are at least a few more places in which kebabizing is used that I'm aware of:
-
during deployment it is used to form the registered agent types that are stored in the db for later lookups. I believe we proabably want to leave such "cross-language" use cases, but let's talk about this during standup
-
this in turn is used by the worker executor to fetch agent type information for rpc driven by the sdks. I think there is currently a mismatch somewhere in there as the sdk is not kebabizing, the worker-executor is not, but the db table includes the the kebabized version
-
It is used for manipulating secrets using the api / specifying defaults during deployments. Still need to think about how the best dx looks like here, again this is a natually "cross-language" use case
-
it is used to detect ambiguous agent types during a deployment\
Contributor
Author
|
Yes these are all finalized in the final step |
* New AgentId format and language-specific rendering, cleanups * More cleanups and tests * Benchmark * Compilation fixes * Unit tests passing * Test adjustments * Fixes * CLI improvements * CLI fixes * cli test fixes * Cleanup * Format * Fixes * analysing ci failures skill * Fix * Add migration 006 to drop agent_wrapper_type_name column Amp-Thread-ID: https://ampcode.com/threads/T-019cc47e-a88c-73f6-86e8-678b8e506697 Co-authored-by: Amp <amp@ampcode.com> * Fixes * Fixes * Eliminated some test-code redundancy * Review feedback --------- Co-authored-by: Amp <amp@ampcode.com>
vigoo
added a commit
that referenced
this pull request
Mar 9, 2026
* Renames * Agent types changes step 4 (#2869) * Normalized SDK metadata to native naming * Prepared helper macros for further tests * Agent types changes step 5 (last) (#2945) * New AgentId format and language-specific rendering, cleanups * More cleanups and tests * Benchmark * Compilation fixes * Unit tests passing * Test adjustments * Fixes * CLI improvements * CLI fixes * cli test fixes * Cleanup * Format * Fixes * analysing ci failures skill * Fix * Add migration 006 to drop agent_wrapper_type_name column Amp-Thread-ID: https://ampcode.com/threads/T-019cc47e-a88c-73f6-86e8-678b8e506697 Co-authored-by: Amp <amp@ampcode.com> * Fixes * Fixes * Eliminated some test-code redundancy * Review feedback --------- Co-authored-by: Amp <amp@ampcode.com> --------- Co-authored-by: Amp <amp@ampcode.com> --------- Co-authored-by: Amp <amp@ampcode.com>
vigoo
added a commit
that referenced
this pull request
Mar 9, 2026
* Removed wrong and unnecessary FromValue instance * TS SDK sets None as constructor name * Renames to improve code consistency (#2867) * Renames * Agent types changes step 4 (#2869) * Normalized SDK metadata to native naming * Prepared helper macros for further tests * Agent types changes step 5 (last) (#2945) * New AgentId format and language-specific rendering, cleanups * More cleanups and tests * Benchmark * Compilation fixes * Unit tests passing * Test adjustments * Fixes * CLI improvements * CLI fixes * cli test fixes * Cleanup * Format * Fixes * analysing ci failures skill * Fix * Add migration 006 to drop agent_wrapper_type_name column Amp-Thread-ID: https://ampcode.com/threads/T-019cc47e-a88c-73f6-86e8-678b8e506697 Co-authored-by: Amp <amp@ampcode.com> * Fixes * Fixes * Eliminated some test-code redundancy * Review feedback --------- Co-authored-by: Amp <amp@ampcode.com> --------- Co-authored-by: Amp <amp@ampcode.com> --------- Co-authored-by: Amp <amp@ampcode.com> * Fixes --------- Co-authored-by: Amp <amp@ampcode.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Step 4 of #2835
Removes "kebabizing" from both SDKs
Introduces some helper macros that can be used in integration tests to convert data values where the type is coming from host-side derived analysed types