agent-config: allow specifying local agent config during agent creation#2870
agent-config: allow specifying local agent config during agent creation#2870mschuwalow merged 7 commits intomainfrom
Conversation
mschuwalow
force-pushed
the
agent-config-worker-creation
branch
3 times, most recently
from
4176faf to
ba326d8
Compare
mschuwalow
force-pushed
the
agent-config-worker-creation
branch
from
c3b1132 to
1a8877e
Compare
| initial_total_linear_memory_size: u64, | ||
| initial_active_plugins: HashSet<PluginPriority>, | ||
| config_vars: BTreeMap<String, String>, | ||
| local_agent_config: Vec<ParsedWorkerCreationLocalAgentConfigEntry>, |
There was a problem hiding this comment.
Could this be just the raw data? The idea is that all raw oplog entries are as concise as possible (for example invocation parameters also are only Value not ValueAndType etc.) and the public one is the enriched, "render friendly" version. If the enrichment can be done on demand based on metadata and oplog entries, then we can use different types in raw vs public.
There was a problem hiding this comment.
Done. We do need the types in the worker status, so this necessitates fetching the component metadata when going from initial oplog entry to the initial worker metadata.
| let agent_type = component.metadata | ||
| .agent_types() | ||
| .iter() | ||
| .find(|at| at.type_name == agent_id.agent_type) |
There was a problem hiding this comment.
There is a find_agent_type_by_name or similar helper for this, I think
| result | ||
| } | ||
|
|
||
| pub fn effective_local_agent_config( |
There was a problem hiding this comment.
Maybe move these config-related helpers to a submodule? This file is getting big :)
mschuwalow
force-pushed
the
agent-config-worker-creation
branch
from
1a8877e to
8b5cd3f
Compare
mschuwalow
force-pushed
the
agent-config-worker-creation
branch
from
bc587ba to
1ca9335
Compare
mschuwalow
force-pushed
the
agent-config-worker-creation
branch
from
1ca9335 to
67d4f38
Compare
2 participants
resolves #2801
resolves #2802
changes look much bigger than they are because of wit / test-component changes