Add agent testing harness for skill verification#2921
Merged
Conversation
Implements the skill testing harness (#2872-#2882, #2898) that validates AI coding agents can discover, load, and follow Golem skill files to produce correct build artifacts. - CLI entrypoint with arg parsing and scenario filtering - YAML scenario loader with Zod schema validation - AgentDriver interface with Claude Code and Gemini (stub) drivers - SkillWatcher with inotifywait (Linux), fswatch (macOS), atime and presence-based fallback detection - Skill activation assertion engine (default, strict, allowedExtras) - Build verification with golem.yaml directory discovery - JSON report generation per scenario run - Bootstrap scenario: golem-new-project-ts - golem-new-project skill (SKILL.md) - CI workflow for unit + integration tests on Ubuntu - 21 unit tests (watcher, executor assertions, loader validation)
|
Thank you for your contribution! Before we can merge this PR, we need you to sign our Contributor License Agreement. Please read the CLA and post the comment below to sign. I have read the CLA Document and I hereby sign the CLA You can retrigger this bot by commenting recheck in this Pull Request. Posted by the CLA Assistant Lite bot. |
Change **/*.test.js to *.test.js since /bin/sh (dash) on Linux does not support globstar. All test files are in a flat directory so ** is unnecessary.
Myestery
force-pushed
the
agent-testing-harness
branch
4 times, most recently
from
28dda12 to
fc5f6f4
Compare
- Download golem v1.4.2 binary from golemcloud/golem releases - Use golem server run with /healthcheck readiness loop - Fix executor health check to use /healthcheck endpoint - Exit with code 1 when any scenario fails
Myestery
force-pushed
the
agent-testing-harness
branch
from
fc5f6f4 to
0ccf003
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
tests/harness/) for validating AI coding agents can discover and follow Golem skill filesgolem-new-projectskill and bootstrap scenario (golem-new-project-ts)skills-test.yaml) with unit tests + integration tests on UbuntuIssues
Closes #2872
Closes #2873
Closes #2874
Closes #2875
Closes #2876
Closes #2877
Closes #2878
Closes #2879
Closes #2880
Closes #2881
Closes #2882
Closes #2898
Closes #2906
Closes #2907
What's included
run.ts): arg parsing, scenario filtering, config summarygolem buildwith automaticgolem.yamldirectory discoveryKey fixes applied during development
stdio: ['pipe', ...]→['ignore', ...]to prevent stdin pipe hang with Claude Codefswatch --event Accessflag (not a supported event type on macOS)findGolemProjectDir()to handlegolem newcreating a subdirectory**/*.test.js→*.test.js) for POSIX shell compatibility/healthcheckinstead of/version)Test plan
cd tests/harness && npm run build && npm test— 21/21 unit tests pass