Merged
Conversation
mschuwalow
reviewed
Mar 4, 2026
| .auto_update_worker(&worker_id, updated_component.revision, false) | ||
| .await?; | ||
|
|
||
| executor |
Contributor
There was a problem hiding this comment.
As an alternative to this there is await_ready_to_process_commands in the worker (not exposed via api currently), which will wait until replay / update is finished
Contributor
Author
There was a problem hiding this comment.
User-facing APIs like invocation supposed to work during those phases too (recovery, update) so this would only be useful for tests like this; on the other hand this kind of waiting based on worker status is what the CLI is also doing if you want to await an update. So I'd keep it like this
mschuwalow
approved these changes
Mar 4, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The test for this was flaky.
The theory is that after confirmation of the interruption (
rx.recv) but before switching to the rejecting deleting state (start_deleting) a new invocation could start, picked from the pending invocation queue but never marked as interrupted/finished.Calling
start_deletingimmediately closes the agent for further incoming invocation before the previously running one is interrupted.Also fixes another flaky test by properly waiting for the auto-update to finish.