Add matrix filtering, retry, resume, cleanup, and HTML reports to harness#2979
Merged
Add matrix filtering, retry, resume, cleanup, and HTML reports to harness#2979
Conversation
vigoo
reviewed
Mar 16, 2026
tests/harness/src/run.ts
Outdated
| artifactPaths: string[]; | ||
| } | ||
|
|
||
| async function cleanupGolemState(cwd: string): Promise<void> { |
Contributor
There was a problem hiding this comment.
This is not really cleaning up everything that is created by a test. I think we should restart the whole server with --clean. (And maybe warn the user interactively, if not running on github)
vigoo
requested changes
Mar 16, 2026
…ness Use golem server clean + restart for full cleanup between scenarios, with interactive confirmation when running on a TTY outside CI.
Myestery
force-pushed
the
harness-issues
branch
from
406f3ba to
2a11e49
Compare
…ness - Golem state cleanup uses golem server clean + restart between scenarios - Interactive TTY confirmation when not running on CI - --no-cleanup flag to skip cleanup - HTML summary report generation
Myestery
force-pushed
the
harness-issues
branch
from
2901297 to
4bc19e1
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
matrixfield; harness skips non-matchingretry: { attempts, delay }with per-attempt result tracking--resume-from <step-id>and--workspace <path>flags to resume execution mid-scenariogolem deploy --reset --yes) between scenarios, with--no-cleanupflagagent,language,os,timestampmetadata +--merge-reportsmodeTest plan
cd tests/harness && npm run buildcompiles cleanlynpm test— all new matrix, retry, and HTML report tests passnpx tsx src/run.ts --helpshows all new flags--merge-reportswith sample summary.json files produces merged-summary.json and report.htmlmatrixandretryblocks loads correctly--resume-fromwith invalid step ID throws descriptive errorCloses #2911, #2916, #2915, #2913, #2912, #2903