Open
Conversation
Code Coverage Report for src/ files
|
0xferit
previously approved these changes
Feb 10, 2026
qGolem
requested changes
Feb 13, 2026
Contributor
qGolem
left a comment
qGolem
left a comment
There was a problem hiding this comment.
get to 95% coverage and attack to a YDS YSS
skimaharvey
force-pushed
the
feature/osu-1490-yield-forwarded
branch
2 times, most recently
from
eaaa209 to
99a9156
Compare
skimaharvey
force-pushed
the
feature/osu-1490-yield-forwarded
branch
2 times, most recently
from
9cea7cc to
2cf0f19
Compare
0xferit
approved these changes
Feb 18, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Replace PaymentSplitter with YieldForwarder for Nouns DAO yield flow
Problem
The current PaymentSplitter is pull-based — it receives profit shares but doesn't redeem them or trigger reports. This requires manual claims and separate keeper logic.
Solution
YieldForwarderis a single-purpose, immutable contract that atomically reports, redeems, and forwards yield in one call:The YieldForwarder acts as both the strategy's keeper (authorized to call
report()) and its donation address (receives profit shares). This eliminates the need for a separate splitter or manual redemption step.Changes
src/core/YieldForwarder.sol— immutablereceiver+keeper, singlereportAndForward(strategy, maxLoss)function, zero-adminsrc/factories/YieldForwarderFactory.sol— CREATE2 factory with deterministic addressing and deployment tracking for governance proposalspartners/nouns_dao/script/GenerateProposalCalldata.s.sol— updated proposal: TX1 deploys forwarder, TX2-4 deploy strategy with forwarder as both keeper and donation addresstest/— 22 unit tests + updated governance integration test