Feature/osu 1505 yieldfowarder with swaps#388
Open
skimaharvey wants to merge 10 commits intofeature/osu-1490-yield-forwardedfrom
Open
Feature/osu 1505 yieldfowarder with swaps#388skimaharvey wants to merge 10 commits intofeature/osu-1490-yield-forwardedfrom
skimaharvey wants to merge 10 commits intofeature/osu-1490-yield-forwardedfrom
Conversation
skimaharvey
changed the base branch from
develop
to
feature/osu-1490-yield-forwarded
Code Coverage Report for src/ files
|
skimaharvey
force-pushed
the
feature/osu-1505-yieldfowarder-with-swaps
branch
from
f23e242 to
c2837a3
Compare
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: f23e2423e9
ℹ️ About Codex in GitHub
Codex has been enabled to automatically review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
When you sign up for Codex through ChatGPT, Codex can also answer questions or update the PR, like "@codex address that feedback".
0xferit
approved these changes
Feb 27, 2026
Contributor
Review finding: silent share burning in
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Adds a pluggable swap layer to the yield forwarding pipeline so that strategy profits can be automatically converted to a different target asset (e.g., USDC -> USDT, USDC -> USDS) before being forwarded to the receiver.
Core contracts
SwappingYieldForwarder— InheritsYieldForwarderand addsreportSwapAndForward(), which redeems to self, swaps via a pluggableISwapper, then forwards the target asset. The inheritedreportAndForward()remains available as a no-swap circuit breaker.ISwapper— Minimal interface (swap(tokenIn, tokenOut, amountIn, minAmountOut, receiver)) for stateless swap adapters.Swap adapters
PSMSwapperCurveSwapperexchange()UniswapV3SwapperAdapterUniswapV4SwapperAdapterzeroForOnedirection config with BalanceDelta extraction for output measurementDesign decisions
reportAndForward().swap(). This keeps adapters stateless and composable.