Feature/osu 1516 a report on the technical side for what we can accomplish#398
Open
skimaharvey wants to merge 2 commits intodevelopfrom
Open
Conversation
skimaharvey
force-pushed
the
feature/osu-1516-a-report-on-the-technical-side-for-what-we-can-accomplish
branch
from
593d551 to
1625510
Compare
Code Coverage Report for src/ files
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
ERC4626Strategyworks out of the box — no new strategy contract neededBaseYieldDonatingIntegrationTestinfrastructure for maximum DRYnessWhat was added
test/integration/strategies/config/KpkTestConfig.soltest/integration/strategies/YieldDonating/KpkERC4626Strategy.t.soltest/integration/strategies/YieldDonating/kpk/KpkUSDCPrimeStrategy.t.soltest/integration/strategies/YieldDonating/kpk/KpkETHPrimeStrategy.t.solKPK vault addresses (Ethereum mainnet)
0xe108fbc04852B5df72f9E44d7C29F47e7A993aDd0xd564F765F9aD3E7d2d6cA782100795a885e8e7C8Test coverage (17 tests per vault, 34 total)
Key finding
All KPK vaults are ERC-4626 (built on Morpho MetaMorpho). There are no ERC-7540 vaults in their ecosystem. The existing
ERC4626Strategy+ERC4626StrategyFactoryhandles integration completely with zero new production code.Test plan
forge test --match-contract KpkUSDCPrimeStrategyTest— 17/17 passforge test --match-contract KpkETHPrimeStrategyTest— 17/17 pass