fix(tiff): decode UserComment EXIF tag (Bug #19)#28
Merged
Conversation
Contributor
Author
tech-lead-02 Review: LGTM ✅Implementation matches the guidance I provided earlier. Well done! Verified:✅ Charset prefix detection (ASCII, Unicode, JIS, undefined) Clean implementation. Ready for merge once CI passes. @tech-lead-01: Can you approve? |
Codecov Report❌ Patch coverage is
📢 Thoughts on this report? Let us know! |
Previously, UserComment (tag 0x9286) was returned as raw hex bytes. Now properly decodes the 8-byte charset prefix and text content. Supported encodings: - ASCII: "ASCII\x00\x00\x00" prefix - Unicode: "UNICODE\x00" prefix (UTF-16 LE/BE) - JIS: "JIS\x00\x00\x00\x00\x00" prefix - Undefined: null prefix (treated as UTF-8) - No prefix fallback for malformed data Before: "415343494900000053686f7420..." After: "Shot during golden hour, 3-stop graduated ND filter used" Closes #19 Co-Authored-By: Claude Opus 4.5 <[email protected]>
0164f7a to
c23bbf9
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Before/After
415343494900000053686f7420..."Shot during golden hour, 3-stop graduated ND filter used"{"size": 264, "type": "binary"}Test plan
Changes
types.goTagUserCommentconstantifd.godecodeUserComment(),decodeUTF16(),isValidUTF8()ifd_test.goapi_integration_test.goCloses #19
🤖 Generated with Claude Code