Skip to content

fix(tiff): add missing tag names and value decoding#40

Merged
rpuneet merged 1 commit intomainfrom
fix/tiff-missing-tags
Feb 8, 2026
Merged

fix(tiff): add missing tag names and value decoding#40
rpuneet merged 1 commit intomainfrom
fix/tiff-missing-tags

Conversation

@rpuneet
Copy link
Contributor

@rpuneet rpuneet commented Feb 8, 2026

Summary

  • Add proper names for 5 standard TIFF 6.0 tags that were displaying as hex IDs
  • Add enum value decoding for tags with known value meanings

Tags Added

Tag ID Name Values
0x010A FillOrder Normal, Reversed
0x0129 PageNumber (no decoding needed)
0x013D Predictor None, Horizontal differencing, Floating point predictor
0x0152 ExtraSamples Unspecified, Associated Alpha, Unassociated Alpha
0x0153 SampleFormat Unsigned integer, Signed integer, IEEE floating point, Undefined

Test plan

  • Unit tests for new tag names in lookup_test.go
  • Unit tests for enum value decoding in values_test.go
  • All existing tests pass (go test ./...)

Fixes #39

🤖 Generated with Claude Code

Add proper names and enum decoding for standard TIFF 6.0 tags:
- FillOrder (0x010A): Normal, Reversed
- PageNumber (0x0129)
- Predictor (0x013D): None, Horizontal differencing, Floating point
- ExtraSamples (0x0152): Unspecified, Associated/Unassociated Alpha
- SampleFormat (0x0153): Unsigned/Signed integer, IEEE float, Undefined

Fixes #39

Co-Authored-By: Claude Opus 4.5 <[email protected]>
@codecov
Copy link

codecov bot commented Feb 8, 2026

Codecov Report

✅ All modified and coverable lines are covered by tests.

📢 Thoughts on this report? Let us know!

@rpuneet rpuneet merged commit 9338d33 into main Feb 8, 2026
7 checks passed
@rpuneet
Copy link
Contributor Author

rpuneet commented Feb 8, 2026

Code Review: APPROVED

Clean implementation adding 5 missing TIFF 6.0 tags with proper enum value decoding:

  • FillOrder (0x010A): Normal, Reversed
  • PageNumber (0x0129): Name only (no decoding needed)
  • Predictor (0x013D): None, Horizontal differencing, Floating point predictor
  • ExtraSamples (0x0152): Unspecified, Associated Alpha, Unassociated Alpha
  • SampleFormat (0x0153): Unsigned integer, Signed integer, IEEE floating point, Undefined

Tests comprehensive. CI passes. Follows existing patterns.

Fixes #39

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

TIFF: Missing tag name decoding for standard tags (Predictor, ExtraSamples, SampleFormat, FillOrder, PageNumber)

1 participant