Merged
Conversation
Decodes Canon MakerNote compound tags into human-readable values: CameraSettings array decoded fields: - Quality (RAW, Fine, Normal, etc.) - FlashMode (Off, Auto, On, Red-eye reduction) - DriveMode (Single, Continuous, etc.) - FocusMode (One-shot AF, AI Servo AF, Manual Focus, etc.) - ImageSize (Large, Medium, Small) - EasyMode (Full auto, Manual, Portrait, Landscape, etc.) - MeteringMode (Evaluative, Spot, Center-weighted, etc.) - ExposureMode (Program AE, Aperture-priority, Manual, etc.) - ImageStabilization (On, Off, Shoot Only) ShotInfo array decoded fields: - WhiteBalance (Auto, Daylight, Cloudy, Flash, etc.) ModelID decoded to camera name: - Maps 80+ Canon camera model IDs to names (EOS 5D, EOS R5, etc.) Closes #36 Co-Authored-By: Claude Opus 4.5 <[email protected]>
Codecov Report❌ Patch coverage is
📢 Thoughts on this report? Let us know! |
Contributor
Author
|
Code Review: APPROVED Excellent implementation of Canon MakerNote value decoding: Strengths:
Coverage Note: Before/After output is much more useful: Fixes #36. Ready to merge. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Before/After
Before:
After:
Decoded Fields
CameraSettings (0x0001):
ShotInfo (0x0004):
ModelID (0x0010):
Test plan
./bin/imx testdata/cr2/sample1.cr2 | grep CanonCloses #36
🤖 Generated with Claude Code