Fix Recharts Tooltip labelFormatter TypeScript error#66
Open
dnlweijers wants to merge 2 commits intogommzystudio:masterfrom
Open
Fix Recharts Tooltip labelFormatter TypeScript error#66dnlweijers wants to merge 2 commits intogommzystudio:masterfrom
dnlweijers wants to merge 2 commits intogommzystudio:masterfrom
Conversation
There was a problem hiding this comment.
Pull request overview
This PR fixes a TypeScript error in the Recharts Tooltip component's labelFormatter prop by replacing the typed parameter with runtime type checking. The change also reformats the chart component code with improved line breaks for better readability.
Changes:
- Modified
labelFormatterto use runtime type checking instead of a typed parameter to resolve TypeScript errors - Reformatted
TooltipandLinecomponents to use multi-line formatting for improved code readability
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
| <div className="bg-white p-6 rounded-xl shadow-sm border border-gray-200 h-[300px]"> | ||
| <h5 className="text-sm font-medium text-gray-500 mb-4">RTT History & Threshold</h5> | ||
| <ResponsiveContainer width="100%" height="100%"> | ||
| <ResponsiveContainer width="100%" height="100%"> |
There was a problem hiding this comment.
The ResponsiveContainer has inconsistent indentation. It should be indented at the same level as the h5 element above it (line 182), which uses 28 spaces (7 levels of 4-space indentation). Currently, it's using 32 spaces (8 levels), making it inconsistent with the surrounding code structure.
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.