Merged
Conversation
Signed-off-by: Robert Zaremba <robert@zaremba.ch>
sczembor
reviewed
Jul 7, 2025
Contributor
There was a problem hiding this comment.
Pull Request Overview
Adds a new GitHub Actions workflow for building and testing Move code in a dedicated container.
- Introduces a
.github/test.ymlworkflow that runs onmerge_groupandpull_requestevents - Uses
tj-actions/changed-filesto conditionally build and test only changed.movefiles - Configures concurrency to cancel in-progress runs on the same branch/workflow
Comments suppressed due to low confidence (3)
.github/test.yml:1
- [nitpick] Consider renaming the workflow file to
build-and-test.ymlfor clearer intent and consistency with its name.
name: Build and test
.github/test.yml:13
- [nitpick] This job handles both build and test steps—consider renaming the job key (and display name) to
build-and-testfor clarity.
test:
.github/test.yml:4
- [nitpick] Add a brief comment explaining the
merge_grouptrigger to help future maintainers understand its purpose.
merge_group:
Signed-off-by: Robert Zaremba <robert@zaremba.ch>
7f14742 to
9da6b16
Compare
Signed-off-by: Robert Zaremba <robert@zaremba.ch>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Adding build and test CI jobs