Skip to content

feat: remove optimistic recordIkaSig polling#324

Merged
Rcc999 merged 4 commits intorayane/event-ika-pollingfrom
rayane/remove-optimistic-ika-sig-polling
Jan 28, 2026
Merged

feat: remove optimistic recordIkaSig polling#324
Rcc999 merged 4 commits intorayane/event-ika-pollingfrom
rayane/remove-optimistic-ika-sig-polling

Conversation

@Rcc999
Copy link
Contributor

@Rcc999 Rcc999 commented Jan 27, 2026

Closes: #293
Merges into : #322

Summary by Sourcery

Handle IKA signature verification and rejection directly in the Sui event indexer and centralize Sui client creation for both indexing and redeem solving.

Bug Fixes:

  • Clear stale sign IDs and allow retries when IKA signatures are rejected instead of leaving redeems blocked.

Enhancements:

  • Verify completed IKA signatures on-chain from CompletedSignEvent and mark corresponding redeem inputs as verified.
  • Look up redeem metadata by sign ID in storage to tie IKA events back to local redeem records.
  • Share a common Sui client pool between the indexer and redeem solver, retrieving the minting signer mnemonic once at startup.
  • Restrict solved redeem processing to inputs without a sign_id, delegating signature verification to the event handler.

…at when we listen to IKA events, we process a redeem request based on the 2 events we listen

Signed-off-by: Rayane Charif <rayane.charif@gonative.cc>
@Rcc999 Rcc999 requested a review from a team as a code owner January 27, 2026 13:31
@sourcery-ai
Copy link
Contributor

sourcery-ai bot commented Jan 27, 2026

🧙 Sourcery is reviewing your pull request!


Tips and commands

Interacting with Sourcery

  • Trigger a new review: Comment @sourcery-ai review on the pull request.
  • Continue discussions: Reply directly to Sourcery's review comments.
  • Generate a GitHub issue from a review comment: Ask Sourcery to create an
    issue from a review comment by replying to it. You can also reply to a
    review comment with @sourcery-ai issue to create an issue from it.
  • Generate a pull request title: Write @sourcery-ai anywhere in the pull
    request title to generate a title at any time. You can also comment
    @sourcery-ai title on the pull request to (re-)generate the title at any time.
  • Generate a pull request summary: Write @sourcery-ai summary anywhere in
    the pull request body to generate a PR summary at any time exactly where you
    want it. You can also comment @sourcery-ai summary on the pull request to
    (re-)generate the summary at any time.
  • Generate reviewer's guide: Comment @sourcery-ai guide on the pull
    request to (re-)generate the reviewer's guide at any time.
  • Resolve all Sourcery comments: Comment @sourcery-ai resolve on the
    pull request to resolve all Sourcery comments. Useful if you've already
    addressed all the comments and don't want to see them anymore.
  • Dismiss all Sourcery reviews: Comment @sourcery-ai dismiss on the pull
    request to dismiss all existing Sourcery reviews. Especially useful if you
    want to start fresh with a new review - don't forget to comment
    @sourcery-ai review to trigger a new review!

Customizing Your Experience

Access your dashboard to:

  • Enable or disable review features such as the Sourcery-generated pull request
    summary, the reviewer's guide, and others.
  • Change the review language.
  • Add, remove or edit custom review instructions.
  • Adjust other review settings.

Getting Help

@Rcc999 Rcc999 changed the title Rayane: remove optimistic recordIkaSig polling feat: remove optimistic recordIkaSig polling Jan 27, 2026
Signed-off-by: Rayane Charif <rayane.charif@gonative.cc>
Copy link
Contributor

@robert-zaremba robert-zaremba left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

pre-approving. Let's update based on the comments, we will do a proper review in the #322

@Rcc999 Rcc999 linked an issue Jan 28, 2026 that may be closed by this pull request
Signed-off-by: Rayane Charif <rayane.charif@gonative.cc>
@Rcc999 Rcc999 merged commit 5f45abf into rayane/event-ika-polling Jan 28, 2026
8 checks passed
@Rcc999 Rcc999 deleted the rayane/remove-optimistic-ika-sig-polling branch January 28, 2026 15:48
Rcc999 added a commit that referenced this pull request Feb 11, 2026
* feat: add IKA coordinator event listening to suis indexer. Events are only logged for now, processing will be added in a follow up PR

Signed-off-by: Rayane Charif <rayane.charif@gonative.cc>

* Resolved AI comments

Signed-off-by: Rayane Charif <rayane.charif@gonative.cc>

* Resolved comments

Signed-off-by: Rayane Charif <rayane.charif@gonative.cc>

* Resolved failing test

Signed-off-by: Rayane Charif <rayane.charif@gonative.cc>

* Resolved comments

Signed-off-by: Rayane Charif <rayane.charif@gonative.cc>

* feat: remove optimistic recordIkaSig polling (#324)

* Removed optimistic polling from recordIkaSig into event handler so that when we listen to IKA events, we process a redeem request based on the 2 events we listen

Signed-off-by: Rayane Charif <rayane.charif@gonative.cc>

* Resolved comments

Signed-off-by: Rayane Charif <rayane.charif@gonative.cc>

* Resolved comments

Signed-off-by: Rayane Charif <rayane.charif@gonative.cc>

---------

Signed-off-by: Rayane Charif <rayane.charif@gonative.cc>

* Resolved typecheck error

Signed-off-by: Rayane Charif <rayane.charif@gonative.cc>

* Resolved comments

Signed-off-by: Rayane Charif <rayane.charif@gonative.cc>

* Resolved comments

Signed-off-by: Rayane Charif <rayane.charif@gonative.cc>

* Resolved AI comments and updated based on today's discussion during planning

Signed-off-by: Rayane Charif <rayane.charif@gonative.cc>

* Resolved comments

Signed-off-by: Rayane Charif <rayane.charif@gonative.cc>

---------

Signed-off-by: Rayane Charif <rayane.charif@gonative.cc>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

nBTC Redeem: use events to handle recordIkaSignature

2 participants