-
Notifications
You must be signed in to change notification settings - Fork 0
feat(btcindexer): secure block ingestion with bearer auth #351
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from 8 commits
Commits
Show all changes
9 commits
Select commit
Hold shift + click to select a range
2ecf57f
authentication for put-blocks; updates to the go and ts clients and u…
sczembor 826cd51
auth + tests
sczembor 12b08a5
secret store in wrangler
sczembor 1f6cb05
apply ai code review suggesitons
sczembor 3affca9
timing attacks prevention
sczembor 95a81a6
move auth logic to lib and reuse it across packages
sczembor 0cca70c
cf-typegen
sczembor 04101cf
Merge branch 'master' into stan/authentication-block-ingestor
sczembor 6eee697
apply code review suggestions
sczembor File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,52 @@ | ||
| import { describe, it, expect } from "bun:test"; | ||
| import { extractBearerToken, isAuthorized } from "@gonative-cc/lib/auth"; | ||
|
|
||
| describe("block-ingestor auth helper", () => { | ||
| const env = { | ||
| AUTH_BEARER_TOKEN: "test-token", | ||
| BtcBlocks: {} as KVNamespace, | ||
| BlockQueue: {} as Queue, | ||
| BtcIndexer: {} as Fetcher, | ||
| } as unknown as Env; | ||
|
|
||
| it("should return false if no auth header", () => { | ||
| const request = new Request("http://localhost"); | ||
| const token = extractBearerToken(request.headers.get("Authorization")); | ||
| expect(isAuthorized(token, env.AUTH_BEARER_TOKEN)).toBe(false); | ||
| }); | ||
|
|
||
| it("should return false if token mismatch", () => { | ||
| const request = new Request("http://localhost", { | ||
| headers: { | ||
| Authorization: "Bearer wrong-token", | ||
| }, | ||
| }); | ||
| const token = extractBearerToken(request.headers.get("Authorization")); | ||
| expect(isAuthorized(token, env.AUTH_BEARER_TOKEN)).toBe(false); | ||
| }); | ||
|
|
||
| it("should return true if token matches", () => { | ||
| const request = new Request("http://localhost", { | ||
| headers: { | ||
| Authorization: "Bearer test-token", | ||
| }, | ||
| }); | ||
| const token = extractBearerToken(request.headers.get("Authorization")); | ||
| expect(isAuthorized(token, env.AUTH_BEARER_TOKEN)).toBe(true); | ||
| }); | ||
|
|
||
| it("should return false if AUTH_BEARER_TOKEN is missing in env", () => { | ||
| const envMissing = { | ||
| BtcBlocks: {} as KVNamespace, | ||
| BlockQueue: {} as Queue, | ||
| BtcIndexer: {} as Fetcher, | ||
| } as unknown as Env; | ||
| const request = new Request("http://localhost", { | ||
| headers: { | ||
| Authorization: "Bearer test-token", | ||
| }, | ||
| }); | ||
| const token = extractBearerToken(request.headers.get("Authorization")); | ||
| expect(isAuthorized(token, envMissing.AUTH_BEARER_TOKEN)).toBe(false); | ||
| }); | ||
| }); |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,33 @@ | ||
| import { timingSafeEqual } from "node:crypto"; | ||
|
|
||
| /** | ||
| * Validates a token against an expected secret using constant-time comparison. | ||
| * @param token The token extracted from the Authorization header | ||
| * @param expectedSecret The expected secret from environment variables | ||
| * @returns true if authorized, false otherwise | ||
| */ | ||
| export function isAuthorized(token: string | null, expectedSecret: string | undefined): boolean { | ||
sczembor marked this conversation as resolved.
Outdated
Show resolved
Hide resolved
|
||
| if (!expectedSecret || !token) { | ||
| return false; | ||
| } | ||
|
|
||
| if (token.length !== expectedSecret.length) { | ||
| return false; | ||
| } | ||
|
|
||
| // we do that to prevent timing attacks | ||
| const encoder = new TextEncoder(); | ||
| return timingSafeEqual(encoder.encode(token), encoder.encode(expectedSecret)); | ||
| } | ||
|
|
||
| /** | ||
| * Extracts the Bearer token from the Authorization header. | ||
| * @param authHeader The value of the Authorization header | ||
| * @returns The token if found and correctly formatted, null otherwise | ||
| */ | ||
| export function extractBearerToken(authHeader: string | null): string | null { | ||
| if (!authHeader || !authHeader.startsWith("Bearer ")) { | ||
| return null; | ||
| } | ||
| return authHeader.substring(7); | ||
| } | ||
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.