Upgrade dependencies and bump authzed/api to v1.45.4#35
Open
tonnenpinguin wants to merge 4 commits intogoodhamgupta:mainfrom
Open
Upgrade dependencies and bump authzed/api to v1.45.4#35tonnenpinguin wants to merge 4 commits intogoodhamgupta:mainfrom
tonnenpinguin wants to merge 4 commits intogoodhamgupta:mainfrom
Conversation
- Bump version to 1.7.0 - Update grpc and protobuf dependencies to versions 0.11.0 and 0.16.0 respectively - Remove deprecated Google RPC modules from the codebase - Add GRPC.Client.Supervisor to the supervision tree in the documentation - Clean up docker-compose-test.yml by removing the version line
| cp -r authzed/api/* lib/api/ | ||
| @echo "Copying files to google/rpc folder..." | ||
| @mkdir -p lib/google | ||
| cp -r google/rpc lib/google/ |
Owner
There was a problem hiding this comment.
Looks like with this change we need to update the CI stage(which generates protobuf files and diffs them against the previous version) to make it green.
Contributor
Author
There was a problem hiding this comment.
Thanks for the quick feedback!
I updated the github action files and since we've already been seeing node deprecation warnings I figured I'd just bump everything to the latest version :)
tonnenpinguin
force-pushed
the
chore/upgrade
branch
from
42e0baa to
dd8bd02
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I regenerated the api client based on authzed/api v1.45.4
Google RPC types are no longer taken from Buf; they come from the googleapis Hex package (pulled in via grpc). I updated the Makefile accordingly.
Important: Users need to add GRPC.Client.Supervisor to their supervision tree (e.g. {GRPC.Client.Supervisor, []} in the app’s children). The gRPC client needs this supervisor to open connections.
Aside from that, typical app code can stay the same if you already pass a single target string to the client.
Authzed.Api.V1.Client
Client.new/3now takes a single endpoint string (e.g. "host:port"), matching GRPC.Stub.connect/2 (including typed forms like ipv4:… / ipv6:… where appropriate).Client.new/4(host + port) remains for backward compatibility but is @deprecated. It no longer calls the deprecated GRPC.Stub.connect/3 path (which can surface as warnings or break warnings_as_errors). Instead it builds a target string and delegates to new/3, so deprecation is our compile-time @deprecated, not the library’s runtime warning.