Skip to content

Skinning: Use separate soyokaze/ folder for skin elements#233

Merged
goodtrailer merged 2 commits intomainfrom
remove-lookup-name
Apr 1, 2025
Merged

Skinning: Use separate soyokaze/ folder for skin elements#233
goodtrailer merged 2 commits intomainfrom
remove-lookup-name

Conversation

@goodtrailer
Copy link
Owner

@goodtrailer goodtrailer commented Apr 1, 2025

Fixes #168.
Fixes #223.

Copied from README.md, which has been updated accordingly:

By default, skin PNGs will be taken from the skin's root folder (i.e. where stable looks for skin PNGs). So certain elements (hit circles, approach circles, judgements) will share the same PNGs as osu!std. However, soyokaze! will also look for skin PNGs inside a separate soyokaze/ folder (i.e. soyokaze/hitcircle@2x.png instead of hitcircle@2x.png), so it is possible to differentiate between soyokaze! and osu!std. For better organization, all soyokaze! PNGs can be placed inside this soyokaze/ folder.

Note that hit circle text is not supported. There doesn't seem to be any easy way to add additional text types, since most of this is implemented via static methods with no immediate extensibility.

@goodtrailer goodtrailer added the enhancement New feature or request label Apr 1, 2025
@goodtrailer goodtrailer self-assigned this Apr 1, 2025
@goodtrailer
Copy link
Owner Author

CodeFactor is so dumb sometimes.

@goodtrailer goodtrailer merged commit 98b3061 into main Apr 1, 2025
1 of 2 checks passed
@goodtrailer goodtrailer added the code quality Improvements to code quality label Apr 1, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

code quality Improvements to code quality enhancement New feature or request

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Allow separate skin elements from osu!std Stop using SoyokazeSkinComponentLookup.LookupName

1 participant