Skip to content

Conversation

@1234-ad
Copy link

@1234-ad 1234-ad commented Jan 7, 2026

Problem

This PR fixes issue #663 - Case-Insensitive Filesystem Collision on macOS: Clause.rkt vs clause.rkt in satore/

On case-insensitive filesystems (macOS and Windows), having both Clause.rkt and clause.rkt in the same directory causes file collisions, making it impossible to clone or work with the repository on these systems.

Solution

Renamed Clause.rkt to clause-struct.rkt to:

  1. Eliminate the filename collision
  2. Better reflect the file's purpose (defining the Clause struct with additional properties)
  3. Maintain clear distinction from clause.rkt (which contains basic clause operations)

Changes Made

  • ✅ Created satore/clause-struct.rkt with the content from Clause.rkt
  • ✅ Deleted satore/Clause.rkt
  • ✅ Updated import statements in all affected files:
    • satore/saturation.rkt (line 22): Changed satore/Clausesatore/clause-struct
    • satore/rewrite-tree.rkt (line 15): Changed satore/Clausesatore/clause-struct
    • satore/unification-tree.rkt (line 21): Changed satore/Clausesatore/clause-struct

Testing

The code should work identically to before, as only the filename and import paths have changed, not the functionality. All imports have been updated to reference the new filename.

Impact

  • Compatibility: Enables macOS and Windows users to clone and work with the repository
  • Breaking Change: None for end users, but developers will need to update any local imports if they have custom code that imports this module
  • File Purpose: The new name clause-struct.rkt better describes the file's contents (Clause struct definition with additional properties)

Fixes #663

… collision

This commit resolves issue google-deepmind#663 by renaming Clause.rkt to clause-struct.rkt.
The original naming caused conflicts on case-insensitive filesystems (macOS/Windows)
where both Clause.rkt and clause.rkt would collide.

The new name better reflects the file's purpose (defining the Clause struct)
and eliminates the filesystem collision issue.
@google-cla
Copy link

google-cla bot commented Jan 7, 2026

Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

View this failed invocation of the CLA check for more information.

For the most up to date status, view the checks section at the bottom of the pull request.

@polarbe
Copy link

polarbe commented Jan 7, 2026 via email

@polarbe
Copy link

polarbe commented Jan 7, 2026 via email

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Case-Insensitive Filesystem Collision on macOS: Clause.rkt vs clause.rkt in satore/

2 participants