fix shape issues, improve performance, make it pip installable, etc#36
Conversation
dm-jrae
left a comment
There was a problem hiding this comment.
Thanks so much for addressing the issues - it's looking great, no worries re. the pull request.
Just want to check on the train script though, it looks like there's no dnc import right now and it should fail. Can you just double check this (haven't unit tested the training script).
| import tensorflow as tf | ||
| import sonnet as snt | ||
|
|
||
| import dnc |
There was a problem hiding this comment.
I think you want this import in, no?
There was a problem hiding this comment.
Sorry I just missed this one. I'm short of budgets and all machines(only 2 actually) at my disposal are busy running something, so I didn't bother to run the script...
Now it seems able to start and run smoothly, but I don't have the computer power to run it through.
If there's any other issues, please don't hesitate to point them out.
dm-jrae
left a comment
There was a problem hiding this comment.
Ok thanks for the fix :-)
This PR is intended to be (hopefully) a better organized one to #35 ...
Recap:
python setup.py sdistunder the root directory of this repo and then install it bypip install ./dist/dnc-0.0.2.tar.gz. Some versioning and author information may not be correct, which can be edited or enriched in thesetup.pyfile.tf.unstackcan't process tensors with partially-known shape info. Methods in theutil.pyare refactored by utilizing a combination of tensor operations as a workaround, meanwhile ensuring those operations can be run in GPU.tf.reduce_prod, see #3957,#8841, andtf.nn.top_k, see #5719).