Fix ReinterpretAsInt causing undefind behavior + segfaulting on release mode #362
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Should fix #23.
I kept getting a segfault when building with
Releasemode forQuadruped Flat(For some reason I don't get it withRelWithDebugInfo). I think it's because in the previous implementation usingreinterpret_castis causing an undefined behavior (Due to type size mismatch?)This is a compiler-explorer link that shows the bug https://godbolt.org/z/hWW5GcGeY
@nimrod-gileadi could you please test this since you ran into the same issue?